From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753066Ab3LJKMc (ORCPT ); Tue, 10 Dec 2013 05:12:32 -0500 Received: from mail9.hitachi.co.jp ([133.145.228.44]:45513 "EHLO mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752436Ab3LJKM2 (ORCPT ); Tue, 10 Dec 2013 05:12:28 -0500 Message-ID: <52A6E914.9050200@hitachi.com> Date: Tue, 10 Dec 2013 19:12:36 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 5.2; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Namhyung Kim Cc: Steven Rostedt , Oleg Nesterov , Srikar Dronamraju , Hyeoncheol Lee , "zhangwei(Jovi)" , Arnaldo Carvalho de Melo , Hemant Kumar , LKML , Namhyung Kim Subject: Re: [PATCH 10/17] tracing/probes: Move 'symbol' fetch method to kprobes References: <1386570005-3368-1-git-send-email-namhyung@kernel.org> <1386570005-3368-11-git-send-email-namhyung@kernel.org> In-Reply-To: <1386570005-3368-11-git-send-email-namhyung@kernel.org> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2013/12/09 15:19), Namhyung Kim wrote: > diff --git a/kernel/trace/trace_probe.h b/kernel/trace/trace_probe.h > index 23b2d83ee5fb..d327a1c21f4b 100644 > --- a/kernel/trace/trace_probe.h > +++ b/kernel/trace/trace_probe.h > @@ -239,6 +239,30 @@ ASSIGN_FETCH_FUNC(bitfield, ftype), \ > extern __weak const struct fetch_type kprobes_fetch_type_table[]; > extern __weak const struct fetch_type uprobes_fetch_type_table[]; > > +#ifdef CONFIG_KPROBE_EVENT > +struct symbol_cache; > +unsigned long update_symbol_cache(struct symbol_cache *sc); > +void free_symbol_cache(struct symbol_cache *sc); > +struct symbol_cache *alloc_symbol_cache(const char *sym, long offset); > +#else > +struct symbol_cache { > +}; > +static unsigned long __used update_symbol_cache(struct symbol_cache *sc) > +{ > + return 0; > +} > + > +static void __used free_symbol_cache(struct symbol_cache *sc) > +{ > +} > + > +static struct symbol_cache * __used > +alloc_symbol_cache(const char *sym, long offset) > +{ > + return NULL; > +} > +#endif /* CONFIG_KPROBE_EVENT */ Hmm, defining non-inline function in the header looks odd. Maybe you'd better do this (or define __weak instances) in trace_probe.c. Thank you, -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com