From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754190Ab3LJPUe (ORCPT ); Tue, 10 Dec 2013 10:20:34 -0500 Received: from mail-pb0-f53.google.com ([209.85.160.53]:34206 "EHLO mail-pb0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754028Ab3LJPUZ (ORCPT ); Tue, 10 Dec 2013 10:20:25 -0500 Message-ID: <52A7312F.9030807@linaro.org> Date: Tue, 10 Dec 2013 23:20:15 +0800 From: Alex Shi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Morten Rasmussen CC: "mingo@redhat.com" , "peterz@infradead.org" , "vincent.guittot@linaro.org" , "daniel.lezcano@linaro.org" , "fweisbec@gmail.com" , "linux@arm.linux.org.uk" , "tony.luck@intel.com" , "fenghua.yu@intel.com" , "tglx@linutronix.de" , "akpm@linux-foundation.org" , "arjan@linux.intel.com" , "pjt@google.com" , "fengguang.wu@intel.com" , "james.hogan@imgtec.com" , "jason.low2@hp.com" , "viresh.kumar@linaro.org" , "hanjun.guo@linaro.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 1/3] nohz_full: fix code sytle issue of tick_nohz_full_stop_tick References: <1386074112-30754-1-git-send-email-alex.shi@linaro.org> <1386074112-30754-2-git-send-email-alex.shi@linaro.org> <20131203150038.GE10134@e103034-lin> In-Reply-To: <20131203150038.GE10134@e103034-lin> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/03/2013 11:00 PM, Morten Rasmussen wrote: > In subject: s/sytle/style/ > > On Tue, Dec 03, 2013 at 12:35:10PM +0000, Alex Shi wrote: >> > Code usually starts with 'tab' instead of 7 'space'es in kernel >> > Found another function has the code style issue too. >>From f594f0b721e57f90b51d0dd1692e5aae67d83b81 Mon Sep 17 00:00:00 2001 From: Alex Shi Date: Thu, 28 Nov 2013 14:27:11 +0800 Subject: [PATCH 1/4] nohz_full: fix code style issue Code usually starts with 'tab' instead of 7 'space'es in kernel. Signed-off-by: Alex Shi --- kernel/sched/core.c | 16 ++++++++-------- kernel/time/tick-sched.c | 16 ++++++++-------- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index c180860..636d89e 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -664,18 +664,18 @@ static inline bool got_nohz_idle_kick(void) #ifdef CONFIG_NO_HZ_FULL bool sched_can_stop_tick(void) { - struct rq *rq; + struct rq *rq; - rq = this_rq(); + rq = this_rq(); - /* Make sure rq->nr_running update is visible after the IPI */ - smp_rmb(); + /* Make sure rq->nr_running update is visible after the IPI */ + smp_rmb(); - /* More than one running task need preemption */ - if (rq->nr_running > 1) - return false; + /* More than one running task need preemption */ + if (rq->nr_running > 1) + return false; - return true; + return true; } #endif /* CONFIG_NO_HZ_FULL */ diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index 3612fc7..b55d1c0 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -681,18 +681,18 @@ out: static void tick_nohz_full_stop_tick(struct tick_sched *ts) { #ifdef CONFIG_NO_HZ_FULL - int cpu = smp_processor_id(); + int cpu = smp_processor_id(); - if (!tick_nohz_full_cpu(cpu) || is_idle_task(current)) - return; + if (!tick_nohz_full_cpu(cpu) || is_idle_task(current)) + return; - if (!ts->tick_stopped && ts->nohz_mode == NOHZ_MODE_INACTIVE) - return; + if (!ts->tick_stopped && ts->nohz_mode == NOHZ_MODE_INACTIVE) + return; - if (!can_stop_full_tick()) - return; + if (!can_stop_full_tick()) + return; - tick_nohz_stop_sched_tick(ts, ktime_get(), cpu); + tick_nohz_stop_sched_tick(ts, ktime_get(), cpu); #endif } -- 1.8.1.2 -- Thanks Alex