* [RESENT PATCH] logfs: Check for the return value after calling find_or_create_page()
@ 2013-12-11 11:29 Younger Liu
0 siblings, 0 replies; only message in thread
From: Younger Liu @ 2013-12-11 11:29 UTC (permalink / raw)
To: Andrew Morton
Cc: joern, prasadjoshi.linux, logfs, kernel, fs-devel, liuyiyang
From: Younger Liu <liuyiyang@hisense.com>
In get_mapping_page(), after calling find_or_create_page(),
the return value should be checked.
This patch has been provided:
http://www.spinics.net/lists/linux-fsdevel/msg66948.html
but not been applied now.
Signed-off-by: Younger Liu <liuyiyang@hisense.com>
Cc: Younger Liu <younger.liucn@gmail.com>
Cc: Vyacheslav Dubeyko <slava@dubeyko.com>
Reviewed-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
---
fs/logfs/segment.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/logfs/segment.c b/fs/logfs/segment.c
index d448a77..7f9b096 100644
--- a/fs/logfs/segment.c
+++ b/fs/logfs/segment.c
@@ -62,7 +62,8 @@ static struct page *get_mapping_page(struct
super_block *sb, pgoff_t index,
page = read_cache_page(mapping, index, filler, sb);
else {
page = find_or_create_page(mapping, index, GFP_NOFS);
- unlock_page(page);
+ if (page)
+ unlock_page(page);
}
return page;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-12-11 11:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-11 11:29 [RESENT PATCH] logfs: Check for the return value after calling find_or_create_page() Younger Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).