From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
David Vrabel <david.vrabel@citrix.com>,
Julien Grall <julien.grall@linaro.org>,
<linux-kernel@vger.kernel.org>, <xen-devel@lists.xenproject.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [Xen-devel] [PATCH RFC] xen-block: correctly define structures in public headers
Date: Wed, 11 Dec 2013 17:23:58 +0100 [thread overview]
Message-ID: <52A8919E.2000805@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1312111618120.7093@kaball.uk.xensource.com>
On 11/12/13 17:18, Stefano Stabellini wrote:
> On Tue, 3 Dec 2013, Konrad Rzeszutek Wilk wrote:
>>>> If Konrad and Boris agree that breaking the kernel's ABI in this way is
>>>> acceptable in this specific case, I'll defer to them.
>>>
>>> My opinion as Xen on ARM hypervisor maintainer is that this is the right
>>> thing to do in this case.
>>
>> Heh. If somebody can guarantee me that (by testing the right variants and
>> mentioning this in the git commit) that this does not break x86, then
>> I am fine.
>>
>> And by 'break x86' I mean that this combination works:
>> 32-bit domU on 64-bit dom0
>> 64-bit domU on 32-bit dom0
>>
>> And perhaps also the obvious:
>> 64-bit domU on 64-bit dom0
>> 32-bit domU on 32-bit dom0
>>
>> Since the xen-blkback has its own version of the structs there is no
>> need to change change newer and older version of it.
>>
>> As long as that works I am OK sticking it in.
>>
>> I think from the ARM perspective it is still in 'experimental' phase
>> so anything goes to make it work under ARM.
>
>
> Roger, can you please test this patch on x86 as suggested by Konrad and
> confirm that it doesn't break anything?
This is not the right patch, the right one is the one posted by Julien:
http://marc.info/?l=linux-kernel&m=138608528604584&w=2
next prev parent reply other threads:[~2013-12-11 16:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 10:57 [PATCH RFC] xen-block: correctly define structures in public headers Roger Pau Monne
2013-12-03 11:01 ` David Vrabel
2013-12-03 11:07 ` [Xen-devel] " Paul Durrant
2013-12-03 11:08 ` Ian Campbell
2013-12-03 11:59 ` David Vrabel
2013-12-03 13:41 ` Ian Campbell
2013-12-03 15:11 ` David Vrabel
2013-12-03 15:17 ` Ian Campbell
2013-12-03 15:51 ` One Thousand Gnomes
2013-12-03 16:06 ` Ian Campbell
2013-12-03 20:11 ` Konrad Rzeszutek Wilk
2013-12-04 9:28 ` Ian Campbell
2013-12-04 9:43 ` Roger Pau Monné
2013-12-04 12:10 ` Ian Campbell
2013-12-04 11:03 ` Stefano Stabellini
2013-12-04 11:33 ` Stefano Stabellini
2013-12-11 16:18 ` Stefano Stabellini
2013-12-11 16:23 ` Roger Pau Monné [this message]
2013-12-11 16:29 ` Stefano Stabellini
2013-12-03 11:09 ` Roger Pau Monné
2013-12-03 11:05 ` [Xen-devel] " Ian Campbell
2013-12-03 11:11 ` Jan Beulich
2013-12-03 11:15 ` Ian Campbell
2013-12-03 11:14 ` Roger Pau Monné
2013-12-03 11:14 ` Jan Beulich
2013-12-03 11:18 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A8919E.2000805@citrix.com \
--to=roger.pau@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=julien.grall@linaro.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox