From: David Ahern <dsahern@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH] perf list: fix --raw-dump
Date: Thu, 12 Dec 2013 09:55:10 -0700 [thread overview]
Message-ID: <52A9EA6E.50205@gmail.com> (raw)
In-Reply-To: <CALkWK0ksAB1xkaCR5jxaN-4n1KL3yQACp_62=ijmFZjj8KNuew@mail.gmail.com>
On 12/12/13, 12:34 AM, Ramkumar Ramachandra wrote:
> David Ahern wrote:
>> Why not make raw_dump a proper argument?
>
> Sure, that'd work too. I was thinking of a minimal way to fix the
> problem myself.
>
>> diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c
>> index 011195e38f21..b553d0c4ca82 100644
>> --- a/tools/perf/builtin-list.c
>> +++ b/tools/perf/builtin-list.c
>> @@ -36,6 +38,10 @@ int cmd_list(int argc, const char
>> print_events(NULL, false);
>> return 0;
>> }
>> + if (raw_dump) {
>> + print_events(NULL, true);
>> + return 0;
>> + }
>
> This won't work because you've put it right below the `if (argc ==
> 0)`, which executes print_events(). You could move it up and get it to
> work.
>
your updated patch looks good to me.
David
next prev parent reply other threads:[~2013-12-12 16:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 10:16 [PATCH] perf list: fix --raw-dump Ramkumar Ramachandra
2013-12-11 21:02 ` David Ahern
2013-12-12 7:34 ` Ramkumar Ramachandra
2013-12-12 16:55 ` David Ahern [this message]
2013-12-16 13:19 ` Arnaldo Carvalho de Melo
2013-12-29 10:11 ` Ramkumar Ramachandra
2013-12-30 15:51 ` Dongsheng Yang
2013-12-16 16:07 ` Dongsheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A9EA6E.50205@gmail.com \
--to=dsahern@gmail.com \
--cc=acme@redhat.com \
--cc=artagnon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox