From: Daniel Borkmann <dborkman@redhat.com>
To: nicolas.dichtel@6wind.com
Cc: Francesco Fusco <ffusco@redhat.com>,
jesse@nicira.com, netdev@vger.kernel.org, dev@openvswitch.org,
Thomas Graf <tgraf@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] lib: introduce arch optimized hash library
Date: Thu, 12 Dec 2013 19:04:14 +0100 [thread overview]
Message-ID: <52A9FA9E.6090604@redhat.com> (raw)
In-Reply-To: <52A9F84F.8060500@6wind.com>
On 12/12/2013 06:54 PM, Nicolas Dichtel wrote:
...
> Is it possible to trace that this comes from the DPDK?
> At least in the commit log, like it was done in the v1.
Hm, that got lost; but we can put that back into the commit log.
In any case, we properly included the header comment, of course.
>> +static inline u32 crc32_u32(u32 crc, u32 val)
>> +{
>> + asm ("crc32l %1,%0\n" : "+r" (crc) : "rm" (val));
> I'm not an expert, but is it not possible to use intrisics functions, like it is
> done in the original code?
Intrinsics are not used/available in the kernel, so we used asm
as everywhere else.
prev parent reply other threads:[~2013-12-12 18:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1386860946-1621-1-git-send-email-ffusco@redhat.com>
2013-12-12 15:09 ` [PATCH net-next v2 1/2] lib: introduce arch optimized hash library Francesco Fusco
2013-12-12 17:54 ` Nicolas Dichtel
2013-12-12 18:04 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A9FA9E.6090604@redhat.com \
--to=dborkman@redhat.com \
--cc=dev@openvswitch.org \
--cc=ffusco@redhat.com \
--cc=jesse@nicira.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=tgraf@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox