[PATCH] HID: hid-multitouch: add support for SiS panel in LG 23ET83V

[PATCH] HID: hid-multitouch: add support for SiS panel in LG 23ET83V

[Emanuel Krenz]

3.12.5-stable patch

--------------------
From: Emanuel Krenz <emanuelkrenz@web.de>

Add support for SiS multitouch panel in the touch monitor LG 23ET83V.

Signed-off-by: Emanuel Krenz <emanuelkrenz@web.de>
Signed-off-by: Forest Bond <forest.bond@rapidrollout.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

I bought an LG 23ET83V multitouch monitor, whose idProduct=1030 wasn't yet included in the hid-multitouch driver (support for SiS panels were just added a few days ago).
So I wrote following patch to include the ID number 1030 and patched the latest stable 3.12.5 kernel. The SiS touchpanel in my monitor works for me now.
This is my first submitted patch by now, hope it's okay.

---
  drivers/hid/hid-core.c          |    1 +
  drivers/hid/hid-ids.h           |    1 +
  drivers/hid/hid-multitouch.c    |    3 +++
  drivers/hid/usbhid/hid-quirks.c |    1 +
  4 files changed, 6 insertions(+)
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1823,6 +1823,7 @@ static const struct hid_device_id hid_ha
  	{ HID_USB_DEVICE(USB_VENDOR_ID_SAMSUNG, USB_DEVICE_ID_SAMSUNG_WIRELESS_KBD_MOUSE) },
  	{ HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS9200_TOUCH) },
  	{ HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS817_TOUCH) },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS1030_TOUCH) },
  	{ HID_USB_DEVICE(USB_VENDOR_ID_SKYCABLE, USB_DEVICE_ID_SKYCABLE_WIRELESS_PRESENTER) },
  	{ HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_BUZZ_CONTROLLER) },
  	{ HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_WIRELESS_BUZZ_CONTROLLER) },
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -755,6 +755,7 @@
  #define USB_VENDOR_ID_SIS2_TOUCH	0x0457
  #define USB_DEVICE_ID_SIS9200_TOUCH	0x9200
  #define USB_DEVICE_ID_SIS817_TOUCH	0x0817
+#define USB_DEVICE_ID_SIS1030_TOUCH	0x1030
  
  #define USB_VENDOR_ID_SKYCABLE			0x1223
  #define	USB_DEVICE_ID_SKYCABLE_WIRELESS_PRESENTER	0x3F07

--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -1306,6 +1306,9 @@ static const struct hid_device_id mt_dev
  	{ .driver_data = MT_CLS_DEFAULT,
  		HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH,
  		USB_DEVICE_ID_SIS817_TOUCH) },
+	{ .driver_data = MT_CLS_DEFAULT,
+		HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH,
+		USB_DEVICE_ID_SIS1030_TOUCH) },
  
  	/* Stantum panels */
  	{ .driver_data = MT_CLS_CONFIDENCE,
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -86,6 +86,7 @@ static const struct hid_blacklist {
  	{ USB_VENDOR_ID_SIGMATEL, USB_DEVICE_ID_SIGMATEL_STMP3780, HID_QUIRK_NOGET },
  	{ USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS9200_TOUCH, HID_QUIRK_NOGET },
  	{ USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS817_TOUCH, HID_QUIRK_NOGET },
+	{ USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS1030_TOUCH, HID_QUIRK_NOGET },
  	{ USB_VENDOR_ID_SUN, USB_DEVICE_ID_RARITAN_KVM_DONGLE, HID_QUIRK_NOGET },
  	{ USB_VENDOR_ID_SYMBOL, USB_DEVICE_ID_SYMBOL_SCANNER_1, HID_QUIRK_NOGET },
  	{ USB_VENDOR_ID_SYMBOL, USB_DEVICE_ID_SYMBOL_SCANNER_2, HID_QUIRK_NOGET },

Re: [PATCH] HID: hid-multitouch: add support for SiS panel in LG 23ET83V

[Greg KH]

On Thu, Dec 12, 2013 at 10:18:08PM +0100, Emanuel Krenz wrote:
> 3.12.5-stable patch
> 
> --------------------
> From: Emanuel Krenz <emanuelkrenz@web.de>
> 
> Add support for SiS multitouch panel in the touch monitor LG 23ET83V.
> 
> Signed-off-by: Emanuel Krenz <emanuelkrenz@web.de>
> Signed-off-by: Forest Bond <forest.bond@rapidrollout.com>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

I signed off on this?  What is the git commit id of the patch in Linus's
tree?

confused,

greg k-h

Re: [PATCH] HID: hid-multitouch: add support for SiS panel in LG 23ET83V

[Jiri Kosina]

On Thu, 12 Dec 2013, Greg KH wrote:

> > 3.12.5-stable patch
> > 
> > --------------------
> > From: Emanuel Krenz <emanuelkrenz@web.de>
> > 
> > Add support for SiS multitouch panel in the touch monitor LG 23ET83V.
> > 
> > Signed-off-by: Emanuel Krenz <emanuelkrenz@web.de>
> > Signed-off-by: Forest Bond <forest.bond@rapidrollout.com>
> > Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> I signed off on this?  What is the git commit id of the patch in Linus's
> tree?

I haven't either, and I don't think I have ever seen this patch (it's 
definitely neither in Linus' nor my tree).

Emanuel, what is going on here, please? Is it that you authored this patch 
yourself, and would like to have it included in Linus' tree (only then it 
can go to -stable)?

If so, please remove all Signoffs of people who haven't provided it to 
you, and resubmit it to maintainer (./scripts/get_maintainer.pl will tell 
you who are proper recepients of this patch).

Thanks,

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] HID: hid-multitouch: add support for SiS panel in LG 23ET83V

[Emanuel Krenz]

Am 13.12.2013 10:39, schrieb Jiri Kosina:
> On Thu, 12 Dec 2013, Greg KH wrote:
>
>>> 3.12.5-stable patch
>>>
>>> --------------------
>>> From: Emanuel Krenz <emanuelkrenz@web.de>
>>>
>>> Add support for SiS multitouch panel in the touch monitor LG 23ET83V.
>>>
>>> Signed-off-by: Emanuel Krenz <emanuelkrenz@web.de>
>>> Signed-off-by: Forest Bond <forest.bond@rapidrollout.com>
>>> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
>>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> I signed off on this?  What is the git commit id of the patch in Linus's
>> tree?
> I haven't either, and I don't think I have ever seen this patch (it's
> definitely neither in Linus' nor my tree).
>
> Emanuel, what is going on here, please? Is it that you authored this patch
> yourself, and would like to have it included in Linus' tree (only then it
> can go to -stable)?
>
> If so, please remove all Signoffs of people who haven't provided it to
> you, and resubmit it to maintainer (./scripts/get_maintainer.pl will tell
> you who are proper recepients of this patch).
>
> Thanks,
>
Hello,
I'm sorry, guys. I thought I have to add those "Signed-off-by" lines to 
mention, where I got the ideas for this patch from.
It was actually this patch: https://lkml.org/lkml/2013/12/2/647
That was obviously a mistake, please forgive me.
As I mentioned, this was my first submitted patch, I was just so excited 
that I might help developing.

Thank you, Jiri, for telling me, to remove this "Signed-off-by" lines 
and resubmit the patch after using get_maintainer.pl.
Now I actually got your name as the maintainer of HID CORE LAYER. So 
i'll send it to you again without those lines, i hope it's correct now.

Thanks, guys, for all your work and help!

[PATCH] HID: hid-multitouch: add support for SiS panel in LG 23ET83V

[Emanuel Krenz]

--------------------
From: Emanuel Krenz <emanuelkrenz@web.de>

Add support for SiS multitouch panel in the touch monitor LG 23ET83V.

---

I bought an LG 23ET83V multitouch monitor, whose idProduct=1030 wasn't 
yet included in the hid-multitouch driver.
So I wrote following patch to include the ID number 1030 and patched the 
latest stable 3.12.5 kernel. The SiS touchpanel in my monitor works for 
me now.
This is my first submitted patch by now, hope it's okay.

------------------

--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1823,6 +1823,7 @@ static const struct hid_device_id hid_ha
      { HID_USB_DEVICE(USB_VENDOR_ID_SAMSUNG, 
USB_DEVICE_ID_SAMSUNG_WIRELESS_KBD_MOUSE) },
      { HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH, 
USB_DEVICE_ID_SIS9200_TOUCH) },
      { HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH, 
USB_DEVICE_ID_SIS817_TOUCH) },
+    { HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH, 
USB_DEVICE_ID_SIS1030_TOUCH) },
      { HID_USB_DEVICE(USB_VENDOR_ID_SKYCABLE, 
USB_DEVICE_ID_SKYCABLE_WIRELESS_PRESENTER) },
      { HID_USB_DEVICE(USB_VENDOR_ID_SONY, 
USB_DEVICE_ID_SONY_BUZZ_CONTROLLER) },
      { HID_USB_DEVICE(USB_VENDOR_ID_SONY, 
USB_DEVICE_ID_SONY_WIRELESS_BUZZ_CONTROLLER) },
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -755,6 +755,7 @@
  #define USB_VENDOR_ID_SIS2_TOUCH    0x0457
  #define USB_DEVICE_ID_SIS9200_TOUCH    0x9200
  #define USB_DEVICE_ID_SIS817_TOUCH    0x0817
+#define USB_DEVICE_ID_SIS1030_TOUCH    0x1030

  #define USB_VENDOR_ID_SKYCABLE            0x1223
  #define    USB_DEVICE_ID_SKYCABLE_WIRELESS_PRESENTER    0x3F07

--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -1306,6 +1306,9 @@ static const struct hid_device_id mt_dev
      { .driver_data = MT_CLS_DEFAULT,
          HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH,
          USB_DEVICE_ID_SIS817_TOUCH) },
+    { .driver_data = MT_CLS_DEFAULT,
+        HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH,
+        USB_DEVICE_ID_SIS1030_TOUCH) },

      /* Stantum panels */
      { .driver_data = MT_CLS_CONFIDENCE,
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -86,6 +86,7 @@ static const struct hid_blacklist {
      { USB_VENDOR_ID_SIGMATEL, USB_DEVICE_ID_SIGMATEL_STMP3780, 
HID_QUIRK_NOGET },
      { USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS9200_TOUCH, 
HID_QUIRK_NOGET },
      { USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS817_TOUCH, 
HID_QUIRK_NOGET },
+    { USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS1030_TOUCH, 
HID_QUIRK_NOGET },
      { USB_VENDOR_ID_SUN, USB_DEVICE_ID_RARITAN_KVM_DONGLE, 
HID_QUIRK_NOGET },
      { USB_VENDOR_ID_SYMBOL, USB_DEVICE_ID_SYMBOL_SCANNER_1, 
HID_QUIRK_NOGET },
      { USB_VENDOR_ID_SYMBOL, USB_DEVICE_ID_SYMBOL_SCANNER_2, 
HID_QUIRK_NOGET },

Re: [PATCH] HID: hid-multitouch: add support for SiS panel in LG 23ET83V

[Jiri Kosina]

On Fri, 13 Dec 2013, Emanuel Krenz wrote:

> > Emanuel, what is going on here, please? Is it that you authored this patch
> > yourself, and would like to have it included in Linus' tree (only then it
> > can go to -stable)?
> > 
> > If so, please remove all Signoffs of people who haven't provided it to
> > you, and resubmit it to maintainer (./scripts/get_maintainer.pl will tell
> > you who are proper recepients of this patch).
> > 
> > Thanks,
> > 
> Hello,
> I'm sorry, guys. I thought I have to add those "Signed-off-by" lines to
> mention, where I got the ideas for this patch from.

For real meaning of Signed-off-by:, please refer to 
Documentation/SubmittingPatches, section 12.

> It was actually this patch: https://lkml.org/lkml/2013/12/2/647 That was 
> obviously a mistake, please forgive me. As I mentioned, this was my 
> first submitted patch, I was just so excited that I might help 
> developing.
> 
> Thank you, Jiri, for telling me, to remove this "Signed-off-by" lines and
> resubmit the patch after using get_maintainer.pl.
> Now I actually got your name as the maintainer of HID CORE LAYER. So i'll send
> it to you again without those lines, i hope it's correct now.

Yup, that is the proper process.

Thanks for submitting the patch, I'll respond to that separately.

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] HID: hid-multitouch: add support for SiS panel in LG 23ET83V

[Jiri Kosina]

On Fri, 13 Dec 2013, Emanuel Krenz wrote:

> From: Emanuel Krenz <emanuelkrenz@web.de>
> 
> Add support for SiS multitouch panel in the touch monitor LG 23ET83V.
> 
> I bought an LG 23ET83V multitouch monitor, whose idProduct=1030 wasn't 
> yet included in the hid-multitouch driver. So I wrote following patch to 
> include the ID number 1030 and patched the latest stable 3.12.5 kernel. 
> The SiS touchpanel in my monitor works for me now. This is my first 
> submitted patch by now, hope it's okay.

Hi Emanuel

This time it doesn't have any Signed-off-by: line, but you should actually 
include your own :)

Also, your mail clinet unfortunately corrupted (line-wrapped) the patch, 
so that it can't be applied. Please fix your mail client so that it 
doesn't corrupt patches -- there are some hints in 
Documentation/email-clients.txt

Thanks,

-- 
Jiri Kosina
SUSE Labs

[PATCH] HID: hid-multitouch: add support for SiS panel in LG 23ET83V

[Emanuel Krenz]

--------------------
From: Emanuel Krenz <emanuelkrenz@web.de>

Add support for SiS multitouch panel in the touch monitor LG 23ET83V.

Signed-off-by: Emanuel Krenz <emanuelkrenz@web.de>

---

I bought an LG 23ET83V multitouch monitor, whose idProduct=1030 wasn't yet included in the hid-multitouch driver.
So I wrote following patch to include the ID number 1030 and patched the latest stable 3.12.5 kernel. The SiS touchpanel in my monitor works for me now.
This is my first submitted patch, hope it's okay now, ...well every beginning is difficult ;-).

------------------ 
 drivers/hid/hid-core.c          |    1 +
 drivers/hid/hid-ids.h           |    1 +
 drivers/hid/hid-multitouch.c    |    3 +++
 drivers/hid/usbhid/hid-quirks.c |    1 +
 4 files changed, 6 insertions(+)
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1823,6 +1823,7 @@ static const struct hid_device_id hid_ha
 	{ HID_USB_DEVICE(USB_VENDOR_ID_SAMSUNG, USB_DEVICE_ID_SAMSUNG_WIRELESS_KBD_MOUSE) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS9200_TOUCH) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS817_TOUCH) },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS1030_TOUCH) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_SKYCABLE, USB_DEVICE_ID_SKYCABLE_WIRELESS_PRESENTER) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_BUZZ_CONTROLLER) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_SONY, USB_DEVICE_ID_SONY_WIRELESS_BUZZ_CONTROLLER) },
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -755,6 +755,7 @@
 #define USB_VENDOR_ID_SIS2_TOUCH	0x0457
 #define USB_DEVICE_ID_SIS9200_TOUCH	0x9200
 #define USB_DEVICE_ID_SIS817_TOUCH	0x0817
+#define USB_DEVICE_ID_SIS1030_TOUCH	0x1030
 
 #define USB_VENDOR_ID_SKYCABLE			0x1223
 #define	USB_DEVICE_ID_SKYCABLE_WIRELESS_PRESENTER	0x3F07

--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -1306,6 +1306,9 @@ static const struct hid_device_id mt_dev
 	{ .driver_data = MT_CLS_DEFAULT,
 		HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH,
 		USB_DEVICE_ID_SIS817_TOUCH) },
+	{ .driver_data = MT_CLS_DEFAULT,
+		HID_USB_DEVICE(USB_VENDOR_ID_SIS2_TOUCH,
+		USB_DEVICE_ID_SIS1030_TOUCH) },
 
 	/* Stantum panels */
 	{ .driver_data = MT_CLS_CONFIDENCE,
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -86,6 +86,7 @@ static const struct hid_blacklist {
 	{ USB_VENDOR_ID_SIGMATEL, USB_DEVICE_ID_SIGMATEL_STMP3780, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS9200_TOUCH, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS817_TOUCH, HID_QUIRK_NOGET },
+	{ USB_VENDOR_ID_SIS2_TOUCH, USB_DEVICE_ID_SIS1030_TOUCH, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_SUN, USB_DEVICE_ID_RARITAN_KVM_DONGLE, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_SYMBOL, USB_DEVICE_ID_SYMBOL_SCANNER_1, HID_QUIRK_NOGET },
 	{ USB_VENDOR_ID_SYMBOL, USB_DEVICE_ID_SYMBOL_SCANNER_2, HID_QUIRK_NOGET },

Re: [PATCH] HID: hid-multitouch: add support for SiS panel in LG 23ET83V

[Jiri Kosina]

On Fri, 13 Dec 2013, Emanuel Krenz wrote:

> I bought an LG 23ET83V multitouch monitor, whose idProduct=1030 wasn't 
> yet included in the hid-multitouch driver. So I wrote following patch to 
> include the ID number 1030 and patched the latest stable 3.12.5 kernel. 
> The SiS touchpanel in my monitor works for me now. This is my first 
> submitted patch, hope it's okay now, ...well every beginning is 
> difficult ;-).

Now applied (after refreshing it to apply on top of the SIS quirk 
merging). Thanks,

-- 
Jiri Kosina
SUSE Labs