From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752126Ab3LMB5B (ORCPT ); Thu, 12 Dec 2013 20:57:01 -0500 Received: from lmv.inov.pt ([146.193.64.2]:33481 "EHLO lmv.inov.pt" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751929Ab3LMBz5 (ORCPT ); Thu, 12 Dec 2013 20:55:57 -0500 Message-ID: <52AA6909.8050200@inov.pt> Date: Fri, 13 Dec 2013 01:55:21 +0000 From: =?ISO-8859-1?Q?Jos=E9_Miguel_Gon=E7alves?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Linus Walleij , Tomasz Figa , Kukjin Kim CC: linux-samsung-soc , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , =?ISO-8859-1?Q?Heiko_St=FCbner?= Subject: Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX. References: <1378889173-7437-1-git-send-email-jose.goncalves@inov.pt> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (lmv.inov.pt [146.193.64.2]); Fri, 13 Dec 2013 01:55:22 +0000 (WET) X-INOV-EmailServer-Information: Please contact the Email service provider for more information X-INOV-EmailServer: Found to be clean X-INOV-EmailServer-From: jose.goncalves@inov.pt Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27-09-2013 15:17, Linus Walleij wrote: > On Wed, Sep 11, 2013 at 10:46 AM, José Miguel Gonçalves > wrote: > >> Some GPIO line limits are incorrectly set which, for instance, >> does not allow nRTS1 (GPH11) configuration on a S3C2416 chip. >> >> Signed-off-by: José Miguel Gonçalves >> --- >> arch/arm/mach-s3c24xx/include/mach/gpio.h | 10 +++++----- > OK but grrrr! > > What needs to happen to the s3c24xx is to get rid of this file. > > - Define ARCH_NR_GPIOS in arch/arm/Kconfig entry > ARCH_NR_GPIO like everyone else > > - Get rid of the config symbol NEED_MACH_GPIO_H > > - Move this file down into arch/arm/mach-s3c24xx/s3c24xx-gpio.h > or whatever and make it local... > > I will try to do this myself if noone else helps out, so I'd like to > carry this patch in the GPIO tree provided I can get an ACK from > the S3C24xx maintainer. Tomasz, is that you or Kukjin? > > (BTW the above maybe goes for S3c64xx as well .. and S5P > oh well I will get to it.) > Was this patch forgotten? José Gonçalves