Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.

Heiko Stübner
2013-12-13T08:42:17Z

Am Freitag, 13. Dezember 2013, 09:12:52 schrieb Linus Walleij:
> On Fri, Dec 13, 2013 at 2:55 AM, José Miguel Gonçalves
>
> <jose.goncalves@inov.pt> wrote:
> > On 27-09-2013 15:17, Linus Walleij wrote:
> >> On Wed, Sep 11, 2013 at 10:46 AM, José Miguel Gonçalves
> >>
> >> <jose.goncalves@inov.pt> wrote:
> >>> Some GPIO line limits are incorrectly set which, for instance,
> >>> does not allow nRTS1 (GPH11) configuration on a S3C2416 chip.
> >>>
> >>> Signed-off-by: José Miguel Gonçalves <jose.goncalves@inov.pt>
> >>> ---
> >>>
> >>> arch/arm/mach-s3c24xx/include/mach/gpio.h | 10 +++++-----
>
> (...)
>
> > Was this patch forgotten?
>
> Not by me, I just never got an ACK from the Samsung maintainers,
> so I can't apply it to the GPIO tree.
>
> Ben, Kukjin: can one of you ACK this so I can take it through the
> GPIO tree?

again not the maintainer :-), but I've looked through the manuals of s3c24xx
socs and the new values look correct [I had looked up the patch content in the
list archive], so

Acked-by: Heiko Stuebner <heiko@sntech.de>

But Jose, you should really really look into moving to devicetree with your
platform, if you're not already doing so. Pinctrl support is already present,
and I'm hopefull the move to the common clock framework I posted a few days
ago might make it too.

Heiko