Re: [PATCH] ARM: S3C24XX: Fix configuration of gpio port sizes on S3C24XX.

Heiko Stübner
2013-12-13T09:29:33Z

Am Freitag, 13. Dezember 2013, 10:24:59 schrieb kgene@kernel.org:
> José Miguel Gonçalves wrote:
> > On 27-09-2013 15:17, Linus Walleij wrote:
> > > On Wed, Sep 11, 2013 at 10:46 AM, José Miguel Gonçalves
> > >
> > > <jose.goncalves@inov.pt> wrote:
> > >> Some GPIO line limits are incorrectly set which, for instance,
> > >> does not allow nRTS1 (GPH11) configuration on a S3C2416 chip.
> > >>
> > >> Signed-off-by: José Miguel Gonçalves <jose.goncalves@inov.pt>
> > >> ---
> > >>
> > >> arch/arm/mach-s3c24xx/include/mach/gpio.h | 10 +++++-----
> > >
> > > OK but grrrr!
> > >
> > > What needs to happen to the s3c24xx is to get rid of this file.
> > >
> > > - Define ARCH_NR_GPIOS in arch/arm/Kconfig entry
> > >
> > > ARCH_NR_GPIO like everyone else
> > >
> > > - Get rid of the config symbol NEED_MACH_GPIO_H
> > >
> > > - Move this file down into arch/arm/mach-s3c24xx/s3c24xx-gpio.h
> > >
> > > or whatever and make it local...
> > >
> > > I will try to do this myself if noone else helps out, so I'd like to
> > > carry this patch in the GPIO tree provided I can get an ACK from
> > > the S3C24xx maintainer. Tomasz, is that you or Kukjin?
> > >
> > > (BTW the above maybe goes for S3c64xx as well .. and S5P
> > > oh well I will get to it.)
> >
> > Was this patch forgotten?
>
> Hi Jose,
>
> Sorry about missing your patch. It's my fault :( and as you know, at this
> moment the file will be removed by Linus' patch...
>
> Anyway, let me look at the Samsung patches closely ;)

The comment that is changed in the header is removed by Linus' patch, but the
change to the gpio driver is still relevant for the time being I'd think.

Heiko