From: Xie XiuQi <xiexiuqi@huawei.com>
To: Corey Minyard <minyard@acm.org>
Cc: Hushiyuan <hushiyuan@huawei.com>,
<openipmi-developer@lists.sourceforge.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Zhangdianfang <zhangdianfang@huawei.com>
Subject: [PATCH 0/2] ipmi: fix timeout calculation when bmc is disconnected
Date: Fri, 13 Dec 2013 10:36:36 +0800 [thread overview]
Message-ID: <52AA72B4.4080807@huawei.com> (raw)
Hu Shiyuan report, when loading ipmi_si module while bmc is
disconnected, we found the timeout is longer than 5 secs.
Actually it takes about 3 mins and 20 secs (HZ=250).
error message as below:
Dec 12 19:08:59 linux kernel: IPMI BT: timeout in RD_WAIT [ ] 1 retries left
Dec 12 19:08:59 linux kernel: BT: write 4 bytes seq=0x01 03 18 00 01
[...]
Dec 12 19:12:19 linux kernel: IPMI BT: timeout in RD_WAIT [ ]
Dec 12 19:12:19 linux kernel: failed 2 retries, sending error response
Dec 12 19:12:19 linux kernel: IPMI: BT reset (takes 5 secs)
Dec 12 19:12:19 linux kernel: IPMI BT: flag reset [ ]
Function wait_for_msg_done() use schedule_timeout_uninterruptible(1)
to sleep 1 tick, so we should subtract jiffies_to_usecs(1) usecs
instead of 100 usecs from timeout.
For more clearly, I used USEC_PER_SEC instead of 1000000.
Xie XiuQi (2):
ipmi: use USEC_PER_SEC instead of 1000000 for more meaningful
ipmi: fix timeout calculation when bmc is disconnected
drivers/char/ipmi/ipmi_bt_sm.c | 8 ++++----
drivers/char/ipmi/ipmi_kcs_sm.c | 4 ++--
drivers/char/ipmi/ipmi_si_intf.c | 2 +-
drivers/char/ipmi/ipmi_smic_sm.c | 2 +-
4 files changed, 8 insertions(+), 8 deletions(-)
--
1.8.2.2
next reply other threads:[~2013-12-13 2:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 2:36 Xie XiuQi [this message]
2013-12-13 2:38 ` [PATCH 1/2] ipmi: use USEC_PER_SEC instead of 1000000 for more meaningful Xie XiuQi
2013-12-13 2:39 ` [PATCH 2/2] ipmi: fix timeout calculation when bmc is disconnected Xie XiuQi
2013-12-13 3:15 ` [PATCH 0/2] " Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AA72B4.4080807@huawei.com \
--to=xiexiuqi@huawei.com \
--cc=hushiyuan@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=zhangdianfang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox