From: Li Zefan <lizefan@huawei.com>
To: Vladimir Davydov <vdavydov@parallels.com>
Cc: <linux-kernel@vger.kernel.org>, <cgroups@vger.kernel.org>,
<devel@openvz.org>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH cgroup/for-3.14] cgroup: fix fail path in cgroup_load_subsys()
Date: Fri, 13 Dec 2013 11:20:50 +0800 [thread overview]
Message-ID: <52AA7D12.2070705@huawei.com> (raw)
In-Reply-To: <1386875828-5075-1-git-send-email-vdavydov@parallels.com>
On 2013/12/13 3:17, Vladimir Davydov wrote:
> Calling cgroup_unload_subsys() from cgroup_load_subsys() after
> online_css() failure will result in a NULL ptr dereference on attempt to
> offline_css(), because online_css() only assigns css to cgroup on
> success. Let's fix that by skipping calls to offline_css() and
> css_free() in cgroup_unload_subsys() if there is no css, and freeing css
> in cgroup_load_subsys() on online_css() failure.
>
> Signed-off-by: Vladimir Davydov <vdavydov@parallels.com>
I don't have strong preference on which way to go.
Acked-by: Li Zefan <lizefan@huawei.com>
next prev parent reply other threads:[~2013-12-13 3:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 19:17 [PATCH cgroup/for-3.14] cgroup: fix fail path in cgroup_load_subsys() Vladimir Davydov
2013-12-13 3:20 ` Li Zefan [this message]
2013-12-13 20:47 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AA7D12.2070705@huawei.com \
--to=lizefan@huawei.com \
--cc=cgroups@vger.kernel.org \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox