Re: [PATCH v2] kernel/locking: mutex: simplify access to the first entry in the wait-list

Peter Zijlstra
2013-12-12T12:52:15Z

On Thu, Dec 12, 2013 at 09:02:07PM +0900, Kyungmin Park wrote:
>
> > -----Original Message-----
> > From: Peter Zijlstra [mailto:peterz@infradead.org]
> > Sent: Thursday, December 12, 2013 8:35 PM
> > To: Andrzej Pietrasiewicz
> > Cc: linux-kernel@vger.kernel.org; Kyungmin Park; Marek Szyprowski; Ingo
> > Molnar
> > Subject: Re: [PATCH v2] kernel/locking: mutex: simplify access to the
> > first entry in the wait-list
> >
> > On Thu, Dec 12, 2013 at 12:29:32PM +0100, Andrzej Pietrasiewicz wrote:
> > > Use list_first_entry instead of explicitly accessing the first entry
> > > with "head".next. The comment one line above becomes obsolete.
> > >
> > > Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
> > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > > ---
> > >
> > > v1..v2:
> > >
> > > - corrected the email address in the second Signed-off-by line
> >
> > Still invalid; the problem is that you appear to have written the patch
> > (you send it and you have first sob).
>
>
> > So what is Kyungmin doing in the line? He did not send me your patch.
>
> Internal review process, and it represents this patch comes from.

For review we have this specific tag, oddly called: 'Reviewed-by'.