Re: [PATCH v2] kernel/locking: mutex: simplify access to the first entry in the wait-list

Ingo Molnar
2013-12-13T14:04:33Z

* Andrzej Pietrasiewicz <andrzej.p@samsung.com> wrote:

> Hello Ingo & Peter,
>
> I added Greg on Cc.
>
> W dniu 12.12.2013 13:52, Peter Zijlstra pisze:
> >On Thu, Dec 12, 2013 at 09:02:07PM +0900, Kyungmin Park wrote:
> >>
> >>>-----Original Message-----
> >>>From: Peter Zijlstra [mailto:peterz@infradead.org]
> >>>Sent: Thursday, December 12, 2013 8:35 PM
> >>>To: Andrzej Pietrasiewicz
> >>>Cc: linux-kernel@vger.kernel.org; Kyungmin Park; Marek Szyprowski; Ingo
> >>>Molnar
> >>>Subject: Re: [PATCH v2] kernel/locking: mutex: simplify access to the
> >>>first entry in the wait-list
> >>>
> >>>On Thu, Dec 12, 2013 at 12:29:32PM +0100, Andrzej Pietrasiewicz wrote:
> >>>>Use list_first_entry instead of explicitly accessing the first entry
> >>>>with "head".next. The comment one line above becomes obsolete.
> >>>>
> >>>>Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
> >>>>Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> >>>>---
>
> For quite a long time I've been sending the same SOB lines to the
> linux-usb list.

They can slip through the cracks - but in the past Linus has
complained about such SOB sequences so it's a real concern.

SOB has a very specific purpose outlined in
Documentation/SubmittingPatches, please use Reviewed-by or other
methods of adding credit to others.

Of course if you write a patch and Kyungmin sends me the patch then
that signoff sequence is completely valid.

Thanks,

Ingo