From: "Éric Piel" <eric.piel@tremplin-utc.net>
To: Rashika Kheria <rashika.kheria@gmail.com>,
Matthew Garrett <matthew.garrett@nebula.com>
Cc: Josh Triplett <josh@joshtriplett.org>,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 1/2] drivers: platform: Mark functions as static in hp_accel.c
Date: Fri, 13 Dec 2013 23:34:57 +0100 [thread overview]
Message-ID: <52AB8B91.1020608@tremplin-utc.net> (raw)
In-Reply-To: <20131213085839.GF4386@leaf>
On 13-12-13 09:58, Josh Triplett wrote:
> On Fri, Dec 13, 2013 at 12:56:34PM +0530, Rashika Kheria wrote:
>> This patch marks the functions lis3lv02d_acpi_init(),
>> lis3lv02d_acpi_read() and lis3lv02d_acpi_write() as static in
>> x86/hp_accel.c because they are not used outside this file.
>>
>> Thus, it also eliminates the following warnings in x86/hp_accel.c:
>> drivers/platform/x86/hp_accel.c:91:5: warning: no previous prototype for ‘lis3lv02d_acpi_init’ [-Wmissing-prototypes]
>> drivers/platform/x86/hp_accel.c:109:5: warning: no previous prototype for ‘lis3lv02d_acpi_read’ [-Wmissing-prototypes]
>> drivers/platform/x86/hp_accel.c:132:5: warning: no previous prototype for ‘lis3lv02d_acpi_write’ [-Wmissing-prototypes]
>>
>> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Yes, looks fine.
Signed-off-by: Éric Piel <eric.piel@tremplin-utc.net>
Matthew, could you pick this patch up in the platform-driver-x86 branch?
Cheers,
Éric
>
>> drivers/platform/x86/hp_accel.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/platform/x86/hp_accel.c b/drivers/platform/x86/hp_accel.c
>> index a8e43cf..01b619e 100644
>> --- a/drivers/platform/x86/hp_accel.c
>> +++ b/drivers/platform/x86/hp_accel.c
>> @@ -88,7 +88,7 @@ MODULE_DEVICE_TABLE(acpi, lis3lv02d_device_ids);
>> *
>> * Returns 0 on success.
>> */
>> -int lis3lv02d_acpi_init(struct lis3lv02d *lis3)
>> +static int lis3lv02d_acpi_init(struct lis3lv02d *lis3)
>> {
>> struct acpi_device *dev = lis3->bus_priv;
>> if (acpi_evaluate_object(dev->handle, METHOD_NAME__INI,
>> @@ -106,7 +106,7 @@ int lis3lv02d_acpi_init(struct lis3lv02d *lis3)
>> *
>> * Returns 0 on success.
>> */
>> -int lis3lv02d_acpi_read(struct lis3lv02d *lis3, int reg, u8 *ret)
>> +static int lis3lv02d_acpi_read(struct lis3lv02d *lis3, int reg, u8 *ret)
>> {
>> struct acpi_device *dev = lis3->bus_priv;
>> union acpi_object arg0 = { ACPI_TYPE_INTEGER };
>> @@ -129,7 +129,7 @@ int lis3lv02d_acpi_read(struct lis3lv02d *lis3, int reg, u8 *ret)
>> *
>> * Returns 0 on success.
>> */
>> -int lis3lv02d_acpi_write(struct lis3lv02d *lis3, int reg, u8 val)
>> +static int lis3lv02d_acpi_write(struct lis3lv02d *lis3, int reg, u8 val)
>> {
>> struct acpi_device *dev = lis3->bus_priv;
>> unsigned long long ret; /* Not used when writting */
>> --
>> 1.7.9.5
>>
prev parent reply other threads:[~2013-12-13 22:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 7:26 [PATCH 1/2] drivers: platform: Mark functions as static in hp_accel.c Rashika Kheria
2013-12-13 7:29 ` [PATCH 2/2] drivers: platform: Include appropriate header file in mxm-wmi.c Rashika Kheria
2013-12-13 8:59 ` Josh Triplett
2013-12-13 8:58 ` [PATCH 1/2] drivers: platform: Mark functions as static in hp_accel.c Josh Triplett
2013-12-13 22:34 ` Éric Piel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AB8B91.1020608@tremplin-utc.net \
--to=eric.piel@tremplin-utc.net \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox