From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754218Ab3LNWTH (ORCPT ); Sat, 14 Dec 2013 17:19:07 -0500 Received: from mail-pb0-f54.google.com ([209.85.160.54]:50842 "EHLO mail-pb0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753950Ab3LNWTG (ORCPT ); Sat, 14 Dec 2013 17:19:06 -0500 Message-ID: <52ACD955.6090900@linaro.org> Date: Sat, 14 Dec 2013 14:19:01 -0800 From: John Stultz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Greg KH CC: LKML , Android Kernel Team , Sumit Semwal , Jesse Barker , Colin Cross Subject: Re: [PATCH 1/2] ion: Don't allow building ION as a module. References: <20131214170618.GA17461@kroah.com> <1387051606-10440-1-git-send-email-john.stultz@linaro.org> <20131214214820.GA26981@kroah.com> In-Reply-To: <20131214214820.GA26981@kroah.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/14/2013 01:48 PM, Greg KH wrote: > On Sat, Dec 14, 2013 at 12:06:45PM -0800, John Stultz wrote: >> ION doesn't export the proper symbols for it to be a module. This >> causes build issues when ION is configured as a module. >> >> Since Andorid kernels rarely use modules (I think recent policy >> requires no modules?), go ahead and set the ION config to a bool >> from the tristate option. >> >> If folks decide ION as a module is important, we will have to go >> through and export the various needed symbols. >> >> Signed-off-by: John Stultz >> --- >> drivers/staging/android/ion/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/android/ion/Kconfig b/drivers/staging/android/ion/Kconfig >> index a342d96..b95281e 100644 >> --- a/drivers/staging/android/ion/Kconfig >> +++ b/drivers/staging/android/ion/Kconfig >> @@ -1,5 +1,5 @@ >> menuconfig ION >> - tristate "Ion Memory Manager" >> + bool "Ion Memory Manager" > Or you can do: > depends on m > and leave it as a "tristate", then when switching it off, I think you > can then be prompted as 'm' again, but I could be wrong about that. > > So should ION ever be able to be built as a module in the future? My understanding is that Android is moving away from using modules, but others could comment more authoritatively. So I don't think this is an issue. But as I said in the patch, if folks do want to have ION as a module, we'll have to export all the various symbols that ION users need. thanks -john