From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754461Ab3LON0a (ORCPT ); Sun, 15 Dec 2013 08:26:30 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:50112 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754402Ab3LON02 (ORCPT ); Sun, 15 Dec 2013 08:26:28 -0500 Message-ID: <52ADADC0.9060906@ti.com> Date: Sun, 15 Dec 2013 18:55:20 +0530 From: Sekhar Nori User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Grygorii Strashko , Linus Walleij , Santosh Shilimkar , CC: , , Subject: Re: [RFC v1 3/9] gpio: davinci: use chained_irq_enter/chained_irq_exit API References: <1385494815-15740-1-git-send-email-grygorii.strashko@ti.com> <1385494815-15740-4-git-send-email-grygorii.strashko@ti.com> In-Reply-To: <1385494815-15740-4-git-send-email-grygorii.strashko@ti.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 27 November 2013 01:10 AM, Grygorii Strashko wrote: > It's unsafe to call IRQ chip callbacks (.irq_mask/irq_unmask/irq_ack) > from chained IRQ handler directly. Because, Davinci GPIO block is used > by different SoCs, which, in turn, have different Main IRQ controllers > (Davinci - aintc, cp-intc; Keystone - arm-gic) which may introduce > diffrent set of IRQ chip callbacks. As result, call of > gpio_irq_handler() on Keysone will simply cause crash the system, > because ARM-GIC implements .irq_eoi() instead of .irq_ack(). > > Hence, fix it by using Kernel chained_irq_enter/chained_irq_exit APIs as > they are intended to handle exact such cases. > > Signed-off-by: Grygorii Strashko Queued with Linus's and Santosh's acks. Thanks, Sekhar