Re: [PATCH] input: egalax: Send touch end event when is about to suspend

Dmitry Torokhov
2013-12-30T00:36:26Z

Hi Felipe,

On Mon, Dec 16, 2013 at 03:45:58PM -0800, Felipe Ferreri Tonello wrote:
> Hi Dmitry,
>
> On 12/15/2013 02:40 AM, Dmitry Torokhov wrote:
> >Hi Felipe,
> >
> >On Tue, Dec 10, 2013 at 04:03:16PM -0800, Felipe F. Tonello wrote:
> >>From: "Felipe F. Tonello" <eu@felipetonello.com>
> >>
> >>This is useful to report for users of this device that don't know anything
> >>about the suspension of the device. So users will receive a touch end event
> >>when the device is about to suspend, making it more user friendly.
> >>
> >>One example of users is the X Server with the evdev input driver. This patch
> >>make sure that the X server will propagate a touch end event to its windows.
> >>
> >
> >Hmm, I would argue we need to do this in input core, similarly to what
> >we do for the keys, so that all drivers would benefit from the change.
> >
> >Thanks.
>
> I agree with you. I didn't do in this case because previous patches
> that I had to change core functionality were declined due the fact
> it's hard to maintain backwards compatibility.
>
> Do you recommend me something in this case?

I am not sure why your other patches were declined, but I think in this
particular case it makes sense to move this functionality into input
core as many multitouch drivers would need it.

Thanks.

--
Dmitry