From: micky <micky_ching@realsil.com.cn>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <sameo@linux.intel.com>, <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>, <wei_wang@realsil.com.cn>,
<rogerable@realtek.com>, <devel@linuxdriverproject.org>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH v3 1/2] mfd: rtsx: reduce code duplication in rtl8411
Date: Wed, 18 Dec 2013 09:17:26 +0800 [thread overview]
Message-ID: <52B0F7A6.20601@realsil.com.cn> (raw)
In-Reply-To: <20131217072842.GZ28413@mwanda>
On 12/17/2013 03:28 PM, Dan Carpenter wrote:
> On Tue, Dec 17, 2013 at 10:36:58AM +0800, micky_ching@realsil.com.cn wrote:
>> diff --git a/drivers/mfd/rtsx_pcr.h b/drivers/mfd/rtsx_pcr.h
>> index 947e79b..26b52ec 100644
>> --- a/drivers/mfd/rtsx_pcr.h
>> +++ b/drivers/mfd/rtsx_pcr.h
>> @@ -63,4 +63,12 @@ static inline u8 map_sd_drive(int idx)
>> #define rtl8411_reg_to_sd30_drive_sel_3v3(reg) (((reg) >> 5) & 0x07)
>> #define rtl8411b_reg_to_sd30_drive_sel_3v3(reg) ((reg) & 0x03)
>>
>> +#define set_pull_ctrl_tables(__device) \
>> +do { \
>> + pcr->sd_pull_ctl_enable_tbl = __device##_sd_pull_ctl_enable_tbl; \
>> + pcr->sd_pull_ctl_disable_tbl = __device##_sd_pull_ctl_disable_tbl; \
>> + pcr->ms_pull_ctl_enable_tbl = __device##_ms_pull_ctl_enable_tbl; \
>> + pcr->ms_pull_ctl_disable_tbl = __device##_ms_pull_ctl_disable_tbl; \
>> +} while (0)
>> +
>> #endif
> This is nasty... With readable code, you should understand just from
> looking at it what the code is doing but this obscures it completely.
> It shouldn't reference the "pcr" variable without passing it in as an
> argument but even with that cleanup I don't really like it.
>
> To be honest, I don't see the problem with the original code.
>
>
Using macro can reduce some code, and define as set_pull_ctl_tables(pcr,
dev)
is much better for understand
next prev parent reply other threads:[~2013-12-18 1:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 2:36 [PATCH v3 0/2] mfd: rtsx: decrease driver size and add new device micky_ching
2013-12-17 2:36 ` [PATCH v3 1/2] mfd: rtsx: reduce code duplication in rtl8411 micky_ching
2013-12-17 7:28 ` Dan Carpenter
2013-12-18 1:17 ` micky [this message]
2013-12-17 8:02 ` Dan Carpenter
2013-12-17 2:36 ` [PATCH v3 2/2] mfd: rtsx: add card reader rtl8402 micky_ching
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B0F7A6.20601@realsil.com.cn \
--to=micky_ching@realsil.com.cn \
--cc=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rogerable@realtek.com \
--cc=sameo@linux.intel.com \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox