public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Gao feng <gaofeng@cn.fujitsu.com>
To: Gao feng <gaofeng@cn.fujitsu.com>, linux-audit@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] audit: fix build error when disable audit
Date: Thu, 19 Dec 2013 10:40:40 +0800	[thread overview]
Message-ID: <52B25CA8.8090806@cn.fujitsu.com> (raw)
In-Reply-To: <1387420469-27665-1-git-send-email-gaofeng@cn.fujitsu.com>

On 12/19/2013 10:34 AM, Gao feng wrote:
> kernel/capability.c: In function ‘SYSC_capset’:
> kernel/capability.c:280:2: warning: passing argument 1 of ‘audit_log_capset’ makes integer from pointer without a cast [enabled by default]
>   audit_log_capset(new, current_cred());
>   ^
> In file included from kernel/capability.c:10:0:
> include/linux/audit.h:400:20: note: expected ‘pid_t’ but argument is of type ‘struct cred *’
>  static inline void audit_log_capset(pid_t pid, const struct cred *new,
>                     ^
> kernel/capability.c:280:2: error: too few arguments to function ‘audit_log_capset’
>   audit_log_capset(new, current_cred());
>   ^
> In file included from kernel/capability.c:10:0:
> include/linux/audit.h:400:20: note: declared here
>  static inline void audit_log_capset(pid_t pid, const struct cred *new,
>                     ^
> make[1]: *** [kernel/capability.o] Error 1
> 

BTW, bug introduced by commmit 26b81eb408c411d86c7cc93278fb88fbcd785f65
audit: Simplify and correct audit_log_capset

  reply	other threads:[~2013-12-19  2:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19  2:34 [PATCH] audit: fix build error when disable audit Gao feng
2013-12-19  2:40 ` Gao feng [this message]
2013-12-20  1:19   ` Richard Guy Briggs
2013-12-20  1:39     ` Gao feng
2013-12-20  1:40       ` Richard Guy Briggs
2013-12-20  2:26         ` Gao feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B25CA8.8090806@cn.fujitsu.com \
    --to=gaofeng@cn.fujitsu.com \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox