From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752521Ab3LSCqx (ORCPT ); Wed, 18 Dec 2013 21:46:53 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:18912 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751239Ab3LSCqw convert rfc822-to-8bit (ORCPT ); Wed, 18 Dec 2013 21:46:52 -0500 X-IronPort-AV: E=Sophos;i="4.95,511,1384272000"; d="scan'208";a="9287858" Message-ID: <52B25CA8.8090806@cn.fujitsu.com> Date: Thu, 19 Dec 2013 10:40:40 +0800 From: Gao feng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Gao feng , linux-audit@redhat.com CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] audit: fix build error when disable audit References: <1387420469-27665-1-git-send-email-gaofeng@cn.fujitsu.com> In-Reply-To: <1387420469-27665-1-git-send-email-gaofeng@cn.fujitsu.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/12/19 10:39:10, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/12/19 10:39:10 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/19/2013 10:34 AM, Gao feng wrote: > kernel/capability.c: In function ‘SYSC_capset’: > kernel/capability.c:280:2: warning: passing argument 1 of ‘audit_log_capset’ makes integer from pointer without a cast [enabled by default] > audit_log_capset(new, current_cred()); > ^ > In file included from kernel/capability.c:10:0: > include/linux/audit.h:400:20: note: expected ‘pid_t’ but argument is of type ‘struct cred *’ > static inline void audit_log_capset(pid_t pid, const struct cred *new, > ^ > kernel/capability.c:280:2: error: too few arguments to function ‘audit_log_capset’ > audit_log_capset(new, current_cred()); > ^ > In file included from kernel/capability.c:10:0: > include/linux/audit.h:400:20: note: declared here > static inline void audit_log_capset(pid_t pid, const struct cred *new, > ^ > make[1]: *** [kernel/capability.o] Error 1 > BTW, bug introduced by commmit 26b81eb408c411d86c7cc93278fb88fbcd785f65 audit: Simplify and correct audit_log_capset