From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756626Ab3LSMMw (ORCPT ); Thu, 19 Dec 2013 07:12:52 -0500 Received: from smtp03.stone-is.org ([87.238.162.66]:54190 "EHLO smtpgw.stone-is.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756611Ab3LSMMs (ORCPT ); Thu, 19 Dec 2013 07:12:48 -0500 X-No-Relay: not in my network X-No-Relay: not in my network X-No-Relay: not in my network X-No-Relay: not in my network X-No-Relay: not in my network X-No-Relay: not in my network X-No-Relay: not in my network X-No-Relay: not in my network X-No-Relay: not in my network X-No-Relay: not in my network X-No-Relay: not in my network X-No-Relay: not in my network X-No-Relay: not in my network X-No-Relay: not in my network X-No-Relay: not in my network X-No-Relay: not in my network Message-ID: <52B2E2B9.1040706@acm.org> Date: Thu, 19 Dec 2013 13:12:41 +0100 From: Bart Van Assche User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Sasha Levin , Christoph Lameter , Greg KH CC: Thomas Gleixner , Russell King - ARM Linux , Pablo Neira Ayuso , Patrick McHardy , kadlec@blackhole.kfki.hu, "David S. Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, LKML , linux-mm@kvack.org, Andrew Morton Subject: Re: netfilter: active obj WARN when cleaning up References: <20131127233415.GB19270@kroah.com> <00000142b4282aaf-913f5e4c-314c-4351-9d24-615e66928157-000000@email.amazonses.com> <20131202164039.GA19937@kroah.com> <00000142b4514eb5-2e8f675d-0ecc-423b-9906-58c5f383089b-000000@email.amazonses.com> <20131202172615.GA4722@kroah.com> <00000142b4aeca89-186fc179-92b8-492f-956c-38a7c196d187-000000@email.amazonses.com> <20131202190814.GA2267@kroah.com> <00000142b4d4360c-5755af87-b9b0-4847-b5fa-7a9dd13b49c5-000000@email.amazonses.com> <20131202212235.GA1297@kroah.com> <00000142b54f6694-c51e81b1-f1a2-483b-a1ce-a2d4cb6b155c-000000@email.amazonses.com> <20131202222208.GB13034@kroah.com> <00000142b90da700-19f6b465-ff15-4b2b-9bcd-b91d71958b7f-000000@email.amazonses.com> <52B0ABB6.8090205@oracle.com> In-Reply-To: <52B0ABB6.8090205@oracle.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/17/13 20:53, Sasha Levin wrote: > I'm still seeing warnings with this patch applied: > > [ 24.900482] WARNING: CPU: 12 PID: 3654 at lib/debugobjects.c:260 > debug_print_object+ > 0x8d/0xb0() > [ 24.900482] ODEBUG: free active (active state 0) object type: > timer_list hint: delay > ed_work_timer_fn+0x0/0x20 > [ 24.900482] Modules linked in: > [ 24.900482] CPU: 12 PID: 3654 Comm: kworker/12:1 Tainted: G > W 3.13.0-rc4-n > ext-20131217-sasha-00013-ga878504-dirty #4149 > [ 24.900482] Workqueue: events kobject_delayed_cleanup > [ 24.900482] 0000000000000104 ffff8804f429bae8 ffffffff8439501c > ffffffff8555a92c > [ 24.900482] ffff8804f429bb38 ffff8804f429bb28 ffffffff8112f8ac > ffff8804f429bb58 > [ 24.900482] ffffffff856a9413 ffff880826333530 ffffffff85c68c40 > ffffffff8801bb58 > [ 24.900482] Call Trace: > [ 24.900482] [] dump_stack+0x52/0x7f > [ 24.900482] [] warn_slowpath_common+0x8c/0xc0 > [ 24.900482] [] warn_slowpath_fmt+0x46/0x50 > [ 24.900482] [] debug_print_object+0x8d/0xb0 > [ 24.900482] [] ? __queue_work+0x3f0/0x3f0 > [ 24.900482] [] __debug_check_no_obj_freed+0xa5/0x220 > [ 24.900482] [] ? rtc_device_release+0x2b/0x40 > [ 24.900482] [] ? rtc_device_release+0x2b/0x40 > [ 24.900482] [] debug_check_no_obj_freed+0x15/0x20 > [ 24.900482] [] kfree+0x21f/0x2e0 > [ 24.900482] [] rtc_device_release+0x2b/0x40 > [ 24.900482] [] device_release+0x65/0xc0 > [ 24.900482] [] kobject_cleanup+0x145/0x190 > [ 24.900482] [] kobject_delayed_cleanup+0xd/0x10 > [ 24.900482] [] process_one_work+0x320/0x530 > [ 24.900482] [] ? process_one_work+0x200/0x530 > [ 24.900482] [] worker_thread+0x215/0x350 > [ 24.900482] [] ? manage_workers+0x180/0x180 > [ 24.900482] [] kthread+0x105/0x110 > [ 24.900482] [] ? set_kthreadd_affinity+0x30/0x30 > [ 24.900482] [] ret_from_fork+0x7c/0xb0 > [ 24.900482] [] ? set_kthreadd_affinity+0x30/0x30 > [ 24.900482] ---[ end trace 45529ebf79b2573e ]--- Can anyone tell me whether the patch below makes sense ? Please note that I'm not familiar with the timer subsystem. diff --git a/kernel/timer.c b/kernel/timer.c index accfd24..828b666 100644 --- a/kernel/timer.c +++ b/kernel/timer.c @@ -969,6 +969,8 @@ int del_timer(struct timer_list *timer) base = lock_timer_base(timer, &flags); ret = detach_if_pending(timer, base, true); spin_unlock_irqrestore(&base->lock, flags); + } else { + debug_deactivate(timer); } return ret;