public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: James Hogan <james.hogan@imgtec.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: <rostedt@goodmis.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	<linux-metag@vger.kernel.org>
Subject: Re: [PATCH] arch: metag: lib: add "umoddi3.S" file for __umoddi3()
Date: Thu, 19 Dec 2013 12:17:31 +0000	[thread overview]
Message-ID: <52B2E3DB.7010008@imgtec.com> (raw)
In-Reply-To: <52B2E0FA.7090805@gmail.com>

On 19/12/13 12:05, Chen Gang wrote:
> Use objdump to get "umoddi3.S" for __umoddi3(), the original binary
> file is "gcc-4.2.4-final/gcc/libgcc/umoddi3.o" which is generated by
> "gcc-4.2.4/gcc/libgcc2.c".
> 
> The relate error with allmodconfig:
> 
>     MODPOST 2909 modules
>   ERROR: "__umoddi3" [drivers/target/target_core_mod.ko] undefined!

_umoddi3 is a 64bit division, which should be using the proper division
functions provided by the kernel in <linux/math64.h>.

It needs fixing wherever it comes from in drivers/target/target_core_mod.ko.

Cheers
James


  reply	other threads:[~2013-12-19 12:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19 12:05 [PATCH] arch: metag: lib: add "umoddi3.S" file for __umoddi3() Chen Gang
2013-12-19 12:17 ` James Hogan [this message]
2013-12-19 13:37   ` Chen Gang
2013-12-19 13:47     ` James Hogan
2013-12-20  1:44       ` Chen Gang
2013-12-20  9:30         ` James Hogan
2013-12-20 10:20           ` Chen Gang
2013-12-20 10:48             ` James Hogan
2013-12-20 11:51               ` Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B2E3DB.7010008@imgtec.com \
    --to=james.hogan@imgtec.com \
    --cc=gang.chen.5i5j@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-metag@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox