Re: [PATCH] Revert "ARC: Add guard macro to uapi/asm/unistd.h"

[Chen Gang <gang.chen.5i5j@gmail.com>]

On 12/19/2013 08:42 PM, Geert Uytterhoeven wrote:
> On Thu, Dec 19, 2013 at 1:34 PM, Chen Gang <gang.chen.5i5j@gmail.com> wrote:
>> On 12/19/2013 07:13 PM, Vineet Gupta wrote:
>>> This reverts commit 97bc386fc12deeb41d5bff33548e3002b258d4e0.
>>>
>>> Generic syscall table generator relies on ARCH unistd.h as follows:
>>>
>>>       void *sys_call_table[NR_syscalls] = {
>>>               [0 ... NR_syscalls-1] = sys_ni_syscall,
>>>       #include <asm/unistd.h>
>>>       };
>>>
>>> And turns out that prior dependencies already include that header by
>>> the time preprocessor hits the above. Meaning ARCH unistd.h needs to be
>>> able to included twice.
>>
>> OK, thanks, it sounds reasonable to me.
>>
>> But why many other architectures contents these guard macros? (arm, sh,
>> blackfin, cris, frv, ia64, m32r, m68k, mips, s390, microblaze, mn10300,
>> parisc, powerpc, sparc, x86). Do they need improvement too?
> 
> Those architectures don't use the generic syscall table generator.
> 

OK, thanks. :-)


> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> 


-- 
Chen Gang

Open, share and attitude like air, water and life which God blessed