From: Denis Turischev <denis.turischev@compulab.co.il>
To: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: [PATCH v1] xhci: Switch Intel Lynx Point ports to EHCI on shutdown
Date: Thu, 19 Dec 2013 19:07:33 +0200 [thread overview]
Message-ID: <52B327D5.3080805@compulab.co.il> (raw)
In-Reply-To: <52B31EDA.60908@compulab.co.il>
The same issue like with Panther Point chipsets. If the USB ports are
switched to xHCI on shutdown, the xHCI host will send a spurious interrupt,
which will wake the system. Some BIOS have work around for this, but not all.
The bug can be avoided if the USB ports are switched back to EHCI on
shutdown.
v1: add new device id locally, not in <linux/pci_ids.h>
Signed-off-by: Denis Turischev <denis@compulab.co.il>
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
--- a/drivers/usb/host/xhci-pci.c 2013-12-19 11:36:12.049589400 +0200
+++ b/drivers/usb/host/xhci-pci.c 2013-12-19 11:37:27.261590385 +0200
@@ -34,6 +34,8 @@
#define PCI_VENDOR_ID_ETRON 0x1b6f
#define PCI_DEVICE_ID_ASROCK_P67 0x7023
+#define PCI_DEVICE_ID_INTEL_LYNXPOINT_XHCI 0x9c31
+
static const char hcd_name[] = "xhci_hcd";
/* called after powerup, by probe or system-pm "wakeup" */
@@ -91,8 +93,9 @@
xhci->quirks |= XHCI_LPM_SUPPORT;
xhci->quirks |= XHCI_INTEL_HOST;
}
- if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
- pdev->device == PCI_DEVICE_ID_INTEL_PANTHERPOINT_XHCI) {
+ if (pdev->vendor == PCI_VENDOR_ID_INTEL && (
+ (pdev->device == PCI_DEVICE_ID_INTEL_PANTHERPOINT_XHCI) ||
+ (pdev->device == PCI_DEVICE_ID_INTEL_LYNXPOINT_XHCI))) {
xhci->quirks |= XHCI_EP_LIMIT_QUIRK;
xhci->limit_active_eps = 64;
xhci->quirks |= XHCI_SW_BW_CHECKING;
next prev parent reply other threads:[~2013-12-19 17:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 16:29 xhci: Switch Intel Lynx Point ports to EHCI on shutdown Denis Turischev
2013-12-19 16:38 ` Greg KH
2013-12-19 17:07 ` Denis Turischev [this message]
2013-12-19 18:21 ` [PATCH v1] " Sarah Sharp
2013-12-20 10:41 ` Denis Turischev
2013-12-20 23:45 ` Sarah Sharp
2013-12-21 16:45 ` Holger Freyther
2013-12-22 7:47 ` Denis Turischev
2014-01-03 0:03 ` Sarah Sharp
2014-01-03 3:40 ` littlebat
2014-01-03 18:14 ` Oliver Neukum
2014-01-03 19:34 ` art1
2014-01-06 12:34 ` Denis Turischev
2014-01-07 10:03 ` Takashi Iwai
2014-01-07 23:11 ` Sarah Sharp
2014-01-08 12:57 ` Denis Turischev
2014-02-04 11:10 ` [PATCH] " Denis Turischev
2014-02-18 7:42 ` [RESEND] " Denis Turischev
2014-02-18 18:54 ` Sarah Sharp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B327D5.3080805@compulab.co.il \
--to=denis.turischev@compulab.co.il \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).