public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: Lee Jones <lee.jones@linaro.org>, Laxman Dewangan <ldewangan@nvidia.com>
Cc: anton@enomsg.org, dwmw2@infradead.org, mark.rutland@arm.com,
	rob@landley.net, ijc+devicetree@hellion.org.uk,
	swarren@nvidia.com, devicetree@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mfd: AS3722: add dt node properties for system power controller
Date: Thu, 19 Dec 2013 12:03:16 -0700	[thread overview]
Message-ID: <52B342F4.1070400@wwwdotorg.org> (raw)
In-Reply-To: <20131219130610.GI27373@lee--X1>

On 12/19/2013 06:06 AM, Lee Jones wrote:
> On Thu, 19 Dec 2013, Laxman Dewangan wrote:
> 
>> ams AS3722 device supports the power off by turning off its all rails.
>>
>> Add dt node properties to enable this functionality on this device.

>> diff --git a/Documentation/devicetree/bindings/mfd/as3722.txt b/Documentation/devicetree/bindings/mfd/as3722.txt

>> +functionality from ams AS3722:
>> +ams,system-power-controller: To enable the power off functionality through
>> +	device.
> 
> Do what with it? "on", "<1>", something else?

It's a Boolean property, so just add the name to the DT, no value.
Admittedly the binding should state this.

The series,

Tested-by: Stephen Warren <swarren@nvidia.com>

  reply	other threads:[~2013-12-19 19:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19 12:57 [PATCH 1/2] mfd: AS3722: add dt node properties for system power controller Laxman Dewangan
2013-12-19 12:57 ` [PATCH 2/2] power: reset: as3722: add power-off driver Laxman Dewangan
2013-12-19 13:06 ` [PATCH 1/2] mfd: AS3722: add dt node properties for system power controller Lee Jones
2013-12-19 19:03   ` Stephen Warren [this message]
2013-12-20 13:47     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B342F4.1070400@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=anton@enomsg.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=ldewangan@nvidia.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=rob@landley.net \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox