From: "H. Peter Anvin" <hpa@zytor.com>
To: mingo@kernel.org, linux-kernel@vger.kernel.org,
arjan@linux.intel.com, peterz@infradead.org, rui.zhang@intel.com,
bitbucket@online.de, rafael.j.wysocki@intel.com, lenb@kernel.org,
tglx@linutronix.de, jacob.jun.pan@linux.intel.com,
hpa@linux.intel.com, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/idle] x86, acpi, idle: Restructure the mwait idle routines
Date: Thu, 19 Dec 2013 12:13:29 -0800 [thread overview]
Message-ID: <52B35369.6070208@zytor.com> (raw)
In-Reply-To: <tip-16824255394f55adf31b9a96a9965d8c15bdac4c@git.kernel.org>
On 12/19/2013 12:09 PM, tip-bot for Peter Zijlstra wrote:
> diff --git a/drivers/thermal/intel_powerclamp.c b/drivers/thermal/intel_powerclamp.c
> index 8f181b3..e8275f2 100644
> --- a/drivers/thermal/intel_powerclamp.c
> +++ b/drivers/thermal/intel_powerclamp.c
> @@ -438,9 +438,7 @@ static int clamp_thread(void *arg)
> */
> local_touch_nmi();
> stop_critical_timings();
> - __monitor((void *)¤t_thread_info()->flags, 0, 0);
> - cpu_relax(); /* allow HT sibling to run */
> - __mwait(eax, ecx);
> + mwait_idle_with_hints(eax, ecx);
> start_critical_timings();
> atomic_inc(&idle_wakeup_counter);
> }
>
Should this cpu_relax() be in the common code as well?
-hpa
next prev parent reply other threads:[~2013-12-19 20:14 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 14:08 [PATCH 00/15] cleanups and optimizations Peter Zijlstra
2013-12-12 14:08 ` [PATCH 01/15] x86, acpi, idle: Restructure the mwait idle routines Peter Zijlstra
2013-12-19 20:09 ` [tip:x86/idle] " tip-bot for Peter Zijlstra
2013-12-19 20:13 ` H. Peter Anvin [this message]
2013-12-19 20:16 ` Peter Zijlstra
2013-12-12 14:08 ` [PATCH 02/15] sched, preempt: Fixup missed PREEMPT_NEED_RESCHED folding Peter Zijlstra
2013-12-12 14:08 ` [PATCH 03/15] preempt, locking: Rework local_bh_{dis,en}able() Peter Zijlstra
2013-12-12 14:08 ` [PATCH 04/15] locking: Optimize lock_bh functions Peter Zijlstra
2013-12-12 14:08 ` [PATCH 05/15] sched, net: Clean up preempt_enable_no_resched() abuse Peter Zijlstra
2013-12-12 14:08 ` [PATCH 06/15] sched, net: Fixup busy_loop_us_clock() Peter Zijlstra
2013-12-12 14:08 ` [PATCH 07/15] sched, thermal: Clean up preempt_enable_no_resched() abuse Peter Zijlstra
2013-12-12 14:08 ` [PATCH 08/15] preempt: Take away preempt_enable_no_resched() from modules Peter Zijlstra
2013-12-12 14:08 ` [PATCH 09/15] x86: Use mul_u64_u32_shr() for native_sched_clock() Peter Zijlstra
2013-12-12 14:08 ` [PATCH 10/15] x86: Move some code around Peter Zijlstra
2013-12-12 14:08 ` [PATCH 11/15] x86: Rewrite cyc2ns to avoid the need to disable IRQs Peter Zijlstra
2014-06-16 17:13 ` Viresh Kumar
2014-06-17 12:15 ` Peter Zijlstra
2014-06-17 12:42 ` Viresh Kumar
2014-06-17 16:32 ` Mauro
2014-06-17 12:47 ` Mauro
2013-12-12 14:08 ` [PATCH 12/15] sched: Remove local_irq_disable() from the clocks Peter Zijlstra
2013-12-12 14:08 ` [PATCH 13/15] sched: Use a static_key for sched_clock_stable Peter Zijlstra
2014-01-21 22:28 ` Sasha Levin
2014-01-22 10:45 ` Peter Zijlstra
2014-01-22 11:59 ` Peter Zijlstra
2014-01-23 1:53 ` Dave Young
2014-01-23 16:46 ` [tip:sched/urgent] sched/clock: Fixup early initialization tip-bot for Peter Zijlstra
2014-01-22 12:00 ` [PATCH 13/15] sched: Use a static_key for sched_clock_stable Markus Trippelsdorf
2014-01-22 12:07 ` Peter Zijlstra
2014-01-22 12:16 ` Peter Zijlstra
2014-01-22 12:26 ` Markus Trippelsdorf
2014-01-22 12:30 ` Peter Zijlstra
2014-01-22 13:14 ` Markus Trippelsdorf
2014-01-22 14:26 ` Sasha Levin
2014-01-22 18:35 ` Markus Trippelsdorf
2014-01-22 18:42 ` Peter Zijlstra
2014-01-22 18:45 ` Markus Trippelsdorf
2014-01-22 19:17 ` Josh Boyer
2014-01-22 19:09 ` Markus Trippelsdorf
2014-01-22 19:12 ` Markus Trippelsdorf
2014-01-22 20:16 ` Peter Zijlstra
2014-01-22 21:08 ` Peter Zijlstra
2014-01-22 21:17 ` Markus Trippelsdorf
2014-01-23 9:48 ` Peter Zijlstra
2014-01-23 10:01 ` Markus Trippelsdorf
2014-01-23 10:04 ` Peter Zijlstra
2014-01-23 13:32 ` Josh Boyer
2014-01-23 16:46 ` [tip:sched/urgent] sched/x86/tsc: Initialize multiplier to 0 tip-bot for Peter Zijlstra
2014-01-22 23:53 ` [PATCH 13/15] sched: Use a static_key for sched_clock_stable Josh Boyer
2014-01-23 1:53 ` Dave Young
2014-01-23 2:10 ` Dave Young
2014-01-23 16:56 ` Peter Zijlstra
2014-01-24 3:15 ` Dave Young
2014-01-24 7:58 ` Ingo Molnar
2014-01-22 17:14 ` Peter Zijlstra
2014-01-22 22:31 ` Sasha Levin
2013-12-12 14:08 ` [PATCH 14/15] sched, clock: Fixup clear_sched_clock_stable() Peter Zijlstra
2013-12-12 14:08 ` [PATCH 15/15] x86: Avoid a runtime condition in native_sched_clock() Peter Zijlstra
2013-12-13 3:30 ` [PATCH 00/15] cleanups and optimizations Mike Galbraith
2013-12-13 10:49 ` Eliezer Tamir
2013-12-13 13:56 ` Peter Zijlstra
2013-12-16 17:48 ` Eliezer Tamir
2013-12-17 13:32 ` Peter Zijlstra
2013-12-17 14:03 ` Eliezer Tamir
2013-12-17 15:13 ` Peter Zijlstra
2013-12-17 18:19 ` Eliezer Tamir
2013-12-17 22:11 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B35369.6070208@zytor.com \
--to=hpa@zytor.com \
--cc=arjan@linux.intel.com \
--cc=bitbucket@online.de \
--cc=hpa@linux.intel.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rui.zhang@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).