From: James Hogan <james.hogan@imgtec.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: <rostedt@goodmis.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
<linux-metag@vger.kernel.org>
Subject: Re: [PATCH] arch: metag: lib: add "umoddi3.S" file for __umoddi3()
Date: Fri, 20 Dec 2013 09:30:44 +0000 [thread overview]
Message-ID: <52B40E44.9040603@imgtec.com> (raw)
In-Reply-To: <52B3A0EA.9010801@gmail.com>
On 20/12/13 01:44, Chen Gang wrote:
> On 12/19/2013 09:47 PM, James Hogan wrote:
>> No, I believe there shouldn't be any use of the C 64bit division/modulo
>> operations in generic kernel code in the first place, so like I said
>> before the code in question should be fixed to use the proper functions
>> in <linux/math64.h>.
>>
>
> OK, thanks, your idea is one of fix ways.
>
> Hmm... for me, it is still not a bad idea to add "__umoddi3" to metag.
NAK
Please read this:
http://yarchive.net/comp/linux/64bit_divide.html
Cheers
James
next prev parent reply other threads:[~2013-12-20 9:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 12:05 [PATCH] arch: metag: lib: add "umoddi3.S" file for __umoddi3() Chen Gang
2013-12-19 12:17 ` James Hogan
2013-12-19 13:37 ` Chen Gang
2013-12-19 13:47 ` James Hogan
2013-12-20 1:44 ` Chen Gang
2013-12-20 9:30 ` James Hogan [this message]
2013-12-20 10:20 ` Chen Gang
2013-12-20 10:48 ` James Hogan
2013-12-20 11:51 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B40E44.9040603@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-metag@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox