From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753926Ab3LTXbG (ORCPT ); Fri, 20 Dec 2013 18:31:06 -0500 Received: from mail-la0-f47.google.com ([209.85.215.47]:49399 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751832Ab3LTXbE (ORCPT ); Fri, 20 Dec 2013 18:31:04 -0500 Message-ID: <52B4E14B.6080208@cogentembedded.com> Date: Sat, 21 Dec 2013 03:31:07 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Sasha Levin , venkat.x.venkatsubra@oracle.com, davem@davemloft.net CC: rds-devel@oss.oracle.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rds: prevent dereference of a NULL device in rds_iw_laddr_check References: <1387581520-10272-1-git-send-email-sasha.levin@oracle.com> In-Reply-To: <1387581520-10272-1-git-send-email-sasha.levin@oracle.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 12/21/2013 02:18 AM, Sasha Levin wrote: > Binding might result in a NULL device which is later dereferenced > without checking. > Signed-off-by: Sasha Levin > --- > net/rds/iw.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > diff --git a/net/rds/iw.c b/net/rds/iw.c > index 7826d46..0298920 100644 > --- a/net/rds/iw.c > +++ b/net/rds/iw.c > @@ -239,7 +239,8 @@ static int rds_iw_laddr_check(__be32 addr) > ret = rdma_bind_addr(cm_id, (struct sockaddr *)&sin); > /* due to this, we will claim to support IB devices unless we > check node_type. */ > - if (ret || cm_id->device->node_type != RDMA_NODE_RNIC) > + if (ret || !cm_id->device || > + cm_id->device->node_type != RDMA_NODE_RNIC) Indent with tabs and then spaces, not with spaces only please, so that the line aligns under 'ret'. WBR, Sergei