* perf and Kconfig
@ 2013-12-21 0:39 Alexis Berlemont
2013-12-21 1:00 ` David Ahern
2013-12-21 3:05 ` Randy Dunlap
0 siblings, 2 replies; 5+ messages in thread
From: Alexis Berlemont @ 2013-12-21 0:39 UTC (permalink / raw)
To: linux-kernel
Hi,
Here is a proposal of a small contribution which tries to fulfill the
task "Use Kconfig to allow selecting features and build minimal
version of perf,..." displayed on the todo page of the perf
wiki (https://perf.wiki.kernel.org/index.php/Todo).
I tried to continue the work started by David Ahern
(https://github.com/dsahern/linux.git branch:perf-config). This
version relies on the features detection tests available in
linux/tools/perf/config/feature-checks so as to enable some
configuration options (at least by default).
This little task is not complete; more Kconfig options should be added
for each perf tool (top, record, report, ...).
I just wanted to ask whether you consider this proposal as interesting
enough for inclusion and if you are ok with the way it is implemented.
The code is available here: https://github.com/aberlemont/linux.git
- branch: perf-config.
Alexis.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: perf and Kconfig
2013-12-21 0:39 perf and Kconfig Alexis Berlemont
@ 2013-12-21 1:00 ` David Ahern
2013-12-23 11:54 ` Jiri Olsa
2013-12-21 3:05 ` Randy Dunlap
1 sibling, 1 reply; 5+ messages in thread
From: David Ahern @ 2013-12-21 1:00 UTC (permalink / raw)
To: Alexis Berlemont, linux-kernel, Jiri Olsa,
Arnaldo Carvalho de Melo, Ingo Molnar
[adding perf maintainers]
On 12/20/13, 5:39 PM, Alexis Berlemont wrote:
> Hi,
>
> Here is a proposal of a small contribution which tries to fulfill the
> task "Use Kconfig to allow selecting features and build minimal
> version of perf,..." displayed on the todo page of the perf
> wiki (https://perf.wiki.kernel.org/index.php/Todo).
>
> I tried to continue the work started by David Ahern
> (https://github.com/dsahern/linux.git branch:perf-config). This
> version relies on the features detection tests available in
> linux/tools/perf/config/feature-checks so as to enable some
> configuration options (at least by default).
>
> This little task is not complete; more Kconfig options should be added
> for each perf tool (top, record, report, ...).
>
> I just wanted to ask whether you consider this proposal as interesting
> enough for inclusion and if you are ok with the way it is implemented.
>
> The code is available here: https://github.com/aberlemont/linux.git
> - branch: perf-config.
I know Jiri has an attempt in his tree and there have been a few
discussions since then as well. I'll take a look at it next week. I
would like to see it completed; I just don't have the time to do it.
David
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: perf and Kconfig
2013-12-21 0:39 perf and Kconfig Alexis Berlemont
2013-12-21 1:00 ` David Ahern
@ 2013-12-21 3:05 ` Randy Dunlap
1 sibling, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2013-12-21 3:05 UTC (permalink / raw)
To: Alexis Berlemont, linux-kernel
On 12/20/13 16:39, Alexis Berlemont wrote:
> Hi,
>
> Here is a proposal of a small contribution which tries to fulfill the
> task "Use Kconfig to allow selecting features and build minimal
> version of perf,..." displayed on the todo page of the perf
> wiki (https://perf.wiki.kernel.org/index.php/Todo).
>
> I tried to continue the work started by David Ahern
> (https://github.com/dsahern/linux.git branch:perf-config). This
> version relies on the features detection tests available in
> linux/tools/perf/config/feature-checks so as to enable some
> configuration options (at least by default).
>
> This little task is not complete; more Kconfig options should be added
> for each perf tool (top, record, report, ...).
>
> I just wanted to ask whether you consider this proposal as interesting
> enough for inclusion and if you are ok with the way it is implemented.
>
> The code is available here: https://github.com/aberlemont/linux.git
> - branch: perf-config.
Hi,
The correct way to have any code reviewed is to post the code (not a link
to it) on the mailing list.
thanks,
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: perf and Kconfig
2013-12-21 1:00 ` David Ahern
@ 2013-12-23 11:54 ` Jiri Olsa
2013-12-28 0:16 ` Alexis Berlemont
0 siblings, 1 reply; 5+ messages in thread
From: Jiri Olsa @ 2013-12-23 11:54 UTC (permalink / raw)
To: David Ahern
Cc: Alexis Berlemont, linux-kernel, Arnaldo Carvalho de Melo,
Ingo Molnar
On Fri, Dec 20, 2013 at 06:00:05PM -0700, David Ahern wrote:
> [adding perf maintainers]
>
> On 12/20/13, 5:39 PM, Alexis Berlemont wrote:
> >Hi,
> >
> >Here is a proposal of a small contribution which tries to fulfill the
> >task "Use Kconfig to allow selecting features and build minimal
> >version of perf,..." displayed on the todo page of the perf
> >wiki (https://perf.wiki.kernel.org/index.php/Todo).
> >
> >I tried to continue the work started by David Ahern
> >(https://github.com/dsahern/linux.git branch:perf-config). This
> >version relies on the features detection tests available in
> >linux/tools/perf/config/feature-checks so as to enable some
> >configuration options (at least by default).
> >
> >This little task is not complete; more Kconfig options should be added
> >for each perf tool (top, record, report, ...).
> >
> >I just wanted to ask whether you consider this proposal as interesting
> >enough for inclusion and if you are ok with the way it is implemented.
> >
> >The code is available here: https://github.com/aberlemont/linux.git
> >- branch: perf-config.
>
> I know Jiri has an attempt in his tree and there have been a few
> discussions since then as well. I'll take a look at it next week. I
> would like to see it completed; I just don't have the time to do it.
hi,
my latest branch (out of sync for long time) for kbuild:
git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
perf/kbuild9
I'll check your changes ;-)
jirka
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: perf and Kconfig
2013-12-23 11:54 ` Jiri Olsa
@ 2013-12-28 0:16 ` Alexis Berlemont
0 siblings, 0 replies; 5+ messages in thread
From: Alexis Berlemont @ 2013-12-28 0:16 UTC (permalink / raw)
To: Jiri Olsa
Cc: David Ahern, linux-kernel, Arnaldo Carvalho de Melo, Ingo Molnar
Hi,
I just checked your branch perf/kbuild9.
Your work is far more elaborate than mine. In my branch, I just reused
the *config targets so as to generate the files .config
include/config/auto.conf(.cmd), ...; after that, I manually modified
Makefile.perf with the variables CONFIG_* instead of using the whole
Kbuild system.
Thank you for your mail, it helped me a lot.
Alexis.
On Mon, Dec 23, 2013 at 12:54 PM, Jiri Olsa <jolsa@redhat.com> wrote:
> On Fri, Dec 20, 2013 at 06:00:05PM -0700, David Ahern wrote:
>> [adding perf maintainers]
>>
>> On 12/20/13, 5:39 PM, Alexis Berlemont wrote:
>> >Hi,
>> >
>> >Here is a proposal of a small contribution which tries to fulfill the
>> >task "Use Kconfig to allow selecting features and build minimal
>> >version of perf,..." displayed on the todo page of the perf
>> >wiki (https://perf.wiki.kernel.org/index.php/Todo).
>> >
>> >I tried to continue the work started by David Ahern
>> >(https://github.com/dsahern/linux.git branch:perf-config). This
>> >version relies on the features detection tests available in
>> >linux/tools/perf/config/feature-checks so as to enable some
>> >configuration options (at least by default).
>> >
>> >This little task is not complete; more Kconfig options should be added
>> >for each perf tool (top, record, report, ...).
>> >
>> >I just wanted to ask whether you consider this proposal as interesting
>> >enough for inclusion and if you are ok with the way it is implemented.
>> >
>> >The code is available here: https://github.com/aberlemont/linux.git
>> >- branch: perf-config.
>>
>> I know Jiri has an attempt in his tree and there have been a few
>> discussions since then as well. I'll take a look at it next week. I
>> would like to see it completed; I just don't have the time to do it.
>
> hi,
> my latest branch (out of sync for long time) for kbuild:
> git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
> perf/kbuild9
>
> I'll check your changes ;-)
>
> jirka
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-12-28 0:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-21 0:39 perf and Kconfig Alexis Berlemont
2013-12-21 1:00 ` David Ahern
2013-12-23 11:54 ` Jiri Olsa
2013-12-28 0:16 ` Alexis Berlemont
2013-12-21 3:05 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox