* [PATCH] drivers: sm7xxfb: Mark function as static in sm7xxfb.c
@ 2013-12-21 10:14 Rashika Kheria
2013-12-21 10:26 ` Josh Triplett
2013-12-21 12:26 ` Javier Muñoz
0 siblings, 2 replies; 3+ messages in thread
From: Rashika Kheria @ 2013-12-21 10:14 UTC (permalink / raw)
To: linux-kernel
Cc: Teddy Wang, Greg Kroah-Hartman, Peter Huewe, Martin Berglund,
Ebru Akagunduz, Javier Muñoz, devel, josh
Mark function smtcfb_setmode() as static in sm7xxfb.c because it is not
used outside this file.
This eliminates the following warning in sm7xxfb.c:
drivers/staging/sm7xxfb/sm7xxfb.c:588:6: warning: no previous prototype for ‘smtcfb_setmode’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c
index ba199ff..f08b216 100644
--- a/drivers/staging/sm7xxfb/sm7xxfb.c
+++ b/drivers/staging/sm7xxfb/sm7xxfb.c
@@ -585,7 +585,7 @@ static void smtc_set_timing(struct smtcfb_info *sfb)
}
}
-void smtcfb_setmode(struct smtcfb_info *sfb)
+static void smtcfb_setmode(struct smtcfb_info *sfb)
{
switch (sfb->fb.var.bits_per_pixel) {
case 32:
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: sm7xxfb: Mark function as static in sm7xxfb.c
2013-12-21 10:14 [PATCH] drivers: sm7xxfb: Mark function as static in sm7xxfb.c Rashika Kheria
@ 2013-12-21 10:26 ` Josh Triplett
2013-12-21 12:26 ` Javier Muñoz
1 sibling, 0 replies; 3+ messages in thread
From: Josh Triplett @ 2013-12-21 10:26 UTC (permalink / raw)
To: Rashika Kheria
Cc: linux-kernel, Teddy Wang, Greg Kroah-Hartman, Peter Huewe,
Martin Berglund, Ebru Akagunduz, Javier Muñoz, devel
On Sat, Dec 21, 2013 at 03:44:13PM +0530, Rashika Kheria wrote:
> Mark function smtcfb_setmode() as static in sm7xxfb.c because it is not
> used outside this file.
>
> This eliminates the following warning in sm7xxfb.c:
> drivers/staging/sm7xxfb/sm7xxfb.c:588:6: warning: no previous prototype for ‘smtcfb_setmode’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c
> index ba199ff..f08b216 100644
> --- a/drivers/staging/sm7xxfb/sm7xxfb.c
> +++ b/drivers/staging/sm7xxfb/sm7xxfb.c
> @@ -585,7 +585,7 @@ static void smtc_set_timing(struct smtcfb_info *sfb)
> }
> }
>
> -void smtcfb_setmode(struct smtcfb_info *sfb)
> +static void smtcfb_setmode(struct smtcfb_info *sfb)
> {
> switch (sfb->fb.var.bits_per_pixel) {
> case 32:
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers: sm7xxfb: Mark function as static in sm7xxfb.c
2013-12-21 10:14 [PATCH] drivers: sm7xxfb: Mark function as static in sm7xxfb.c Rashika Kheria
2013-12-21 10:26 ` Josh Triplett
@ 2013-12-21 12:26 ` Javier Muñoz
1 sibling, 0 replies; 3+ messages in thread
From: Javier Muñoz @ 2013-12-21 12:26 UTC (permalink / raw)
To: Rashika Kheria
Cc: linux-kernel, Teddy Wang, Greg Kroah-Hartman, Peter Huewe,
Martin Berglund, Ebru Akagunduz, devel, josh
On 12/21/2013 11:14 AM, Rashika Kheria wrote:
> Mark function smtcfb_setmode() as static in sm7xxfb.c because it is not
> used outside this file.
>
> This eliminates the following warning in sm7xxfb.c:
> drivers/staging/sm7xxfb/sm7xxfb.c:588:6: warning: no previous prototype for ‘smtcfb_setmode’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Acked-by: Javier M. Mellid <jmunhoz@igalia.com>
> ---
> drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c
> index ba199ff..f08b216 100644
> --- a/drivers/staging/sm7xxfb/sm7xxfb.c
> +++ b/drivers/staging/sm7xxfb/sm7xxfb.c
> @@ -585,7 +585,7 @@ static void smtc_set_timing(struct smtcfb_info *sfb)
> }
> }
>
> -void smtcfb_setmode(struct smtcfb_info *sfb)
> +static void smtcfb_setmode(struct smtcfb_info *sfb)
> {
> switch (sfb->fb.var.bits_per_pixel) {
> case 32:
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-21 12:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-21 10:14 [PATCH] drivers: sm7xxfb: Mark function as static in sm7xxfb.c Rashika Kheria
2013-12-21 10:26 ` Josh Triplett
2013-12-21 12:26 ` Javier Muñoz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox