* [PATCH 1/1] extcon: gpio: Add power resume support @ 2013-12-20 8:09 rjying 2013-12-23 4:20 ` Chanwoo Choi 0 siblings, 1 reply; 9+ messages in thread From: rjying @ 2013-12-20 8:09 UTC (permalink / raw) To: MyungJoo Ham, Chanwoo Choi Cc: linux-kernel, Barry Song, RongJun Ying, Binghua Duan, Rongjun Ying From: Rongjun Ying <rongjun.ying@csr.com> After system resume, need send extcon uevent to userspace Change-Id: I32a9e1c6646035f95765bba79a7acaccb8ce45a7 Signed-off-by: Rongjun Ying <rongjun.ying@csr.com> --- drivers/extcon/extcon-gpio.c | 17 +++++++++++++++++ 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c index 7e0dff5..d916522 100644 --- a/drivers/extcon/extcon-gpio.c +++ b/drivers/extcon/extcon-gpio.c @@ -159,12 +159,29 @@ static int gpio_extcon_remove(struct platform_device *pdev) return 0; } +#ifdef CONFIG_PM_SLEEP +static int gpio_extcon_resume(struct device *dev) +{ + struct gpio_extcon_data *extcon_data; + + extcon_data = dev_get_drvdata(dev); + queue_delayed_work(system_power_efficient_wq, &extcon_data->work, + extcon_data->debounce_jiffies); + return 0; +} +#endif + +static const struct dev_pm_ops gpio_extcon_pm_ops = { + SET_SYSTEM_SLEEP_PM_OPS(NULL, gpio_extcon_resume) +}; + static struct platform_driver gpio_extcon_driver = { .probe = gpio_extcon_probe, .remove = gpio_extcon_remove, .driver = { .name = "extcon-gpio", .owner = THIS_MODULE, + .pm = &gpio_extcon_pm_ops, }, }; -- 1.7.5.4 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] extcon: gpio: Add power resume support 2013-12-20 8:09 [PATCH 1/1] extcon: gpio: Add power resume support rjying @ 2013-12-23 4:20 ` Chanwoo Choi 2013-12-23 6:10 ` Barry Song 0 siblings, 1 reply; 9+ messages in thread From: Chanwoo Choi @ 2013-12-23 4:20 UTC (permalink / raw) To: rjying; +Cc: MyungJoo Ham, linux-kernel, Barry Song, RongJun Ying, Binghua Duan On 12/20/2013 05:09 PM, rjying wrote: > From: Rongjun Ying <rongjun.ying@csr.com> > > After system resume, need send extcon uevent to userspace Why did extcon send uevent after wakeup from suspend? If extcon cable is attatched or detached on suspend state, Kernel can detect the interrupt about changed state of extcon. So, kernel would execute proper operation about interrupt after wakeup from suspend state. I think it isn't necessary. Thanks, Chanwoo Choi > > Change-Id: I32a9e1c6646035f95765bba79a7acaccb8ce45a7 > > Signed-off-by: Rongjun Ying <rongjun.ying@csr.com> > --- > drivers/extcon/extcon-gpio.c | 17 +++++++++++++++++ > 1 files changed, 17 insertions(+), 0 deletions(-) > > diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c > index 7e0dff5..d916522 100644 > --- a/drivers/extcon/extcon-gpio.c > +++ b/drivers/extcon/extcon-gpio.c > @@ -159,12 +159,29 @@ static int gpio_extcon_remove(struct platform_device *pdev) > return 0; > } > > +#ifdef CONFIG_PM_SLEEP > +static int gpio_extcon_resume(struct device *dev) > +{ > + struct gpio_extcon_data *extcon_data; > + > + extcon_data = dev_get_drvdata(dev); > + queue_delayed_work(system_power_efficient_wq, &extcon_data->work, > + extcon_data->debounce_jiffies); > + return 0; > +} > +#endif > + > +static const struct dev_pm_ops gpio_extcon_pm_ops = { > + SET_SYSTEM_SLEEP_PM_OPS(NULL, gpio_extcon_resume) > +}; > + > static struct platform_driver gpio_extcon_driver = { > .probe = gpio_extcon_probe, > .remove = gpio_extcon_remove, > .driver = { > .name = "extcon-gpio", > .owner = THIS_MODULE, > + .pm = &gpio_extcon_pm_ops, > }, > }; > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] extcon: gpio: Add power resume support 2013-12-23 4:20 ` Chanwoo Choi @ 2013-12-23 6:10 ` Barry Song 2013-12-23 6:34 ` Chanwoo Choi 0 siblings, 1 reply; 9+ messages in thread From: Barry Song @ 2013-12-23 6:10 UTC (permalink / raw) To: Chanwoo Choi; +Cc: rjying, MyungJoo Ham, LKML, RongJun Ying, Binghua Duan 2013/12/23 Chanwoo Choi <cw00.choi@samsung.com>: > On 12/20/2013 05:09 PM, rjying wrote: >> From: Rongjun Ying <rongjun.ying@csr.com> >> >> After system resume, need send extcon uevent to userspace > > Why did extcon send uevent after wakeup from suspend? > > If extcon cable is attatched or detached on suspend state, > Kernel can detect the interrupt about changed state of extcon. irq controller has lost power in suspend, so there is no pending interrupt. and HW will not pend any interrupt when we hotplug cable during sleep. > So, kernel would execute proper operation about interrupt > after wakeup from suspend state. kernel only save/restore the register status of gpio, how could it know whether there is a pending interrupt if the HW doesn't do it? > > I think it isn't necessary. > > Thanks, > Chanwoo Choi > >> >> Change-Id: I32a9e1c6646035f95765bba79a7acaccb8ce45a7 >> >> Signed-off-by: Rongjun Ying <rongjun.ying@csr.com> >> --- >> drivers/extcon/extcon-gpio.c | 17 +++++++++++++++++ >> 1 files changed, 17 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c >> index 7e0dff5..d916522 100644 >> --- a/drivers/extcon/extcon-gpio.c >> +++ b/drivers/extcon/extcon-gpio.c >> @@ -159,12 +159,29 @@ static int gpio_extcon_remove(struct platform_device *pdev) >> return 0; >> } >> >> +#ifdef CONFIG_PM_SLEEP >> +static int gpio_extcon_resume(struct device *dev) >> +{ >> + struct gpio_extcon_data *extcon_data; >> + >> + extcon_data = dev_get_drvdata(dev); >> + queue_delayed_work(system_power_efficient_wq, &extcon_data->work, >> + extcon_data->debounce_jiffies); >> + return 0; >> +} >> +#endif >> + >> +static const struct dev_pm_ops gpio_extcon_pm_ops = { >> + SET_SYSTEM_SLEEP_PM_OPS(NULL, gpio_extcon_resume) >> +}; >> + >> static struct platform_driver gpio_extcon_driver = { >> .probe = gpio_extcon_probe, >> .remove = gpio_extcon_remove, >> .driver = { >> .name = "extcon-gpio", >> .owner = THIS_MODULE, >> + .pm = &gpio_extcon_pm_ops, >> }, >> }; >> >> > -barry ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] extcon: gpio: Add power resume support 2013-12-23 6:10 ` Barry Song @ 2013-12-23 6:34 ` Chanwoo Choi 2013-12-23 7:36 ` Barry Song 0 siblings, 1 reply; 9+ messages in thread From: Chanwoo Choi @ 2013-12-23 6:34 UTC (permalink / raw) To: Barry Song; +Cc: rjying, MyungJoo Ham, LKML, RongJun Ying, Binghua Duan On 12/23/2013 03:10 PM, Barry Song wrote: > 2013/12/23 Chanwoo Choi <cw00.choi@samsung.com>: >> On 12/20/2013 05:09 PM, rjying wrote: >>> From: Rongjun Ying <rongjun.ying@csr.com> >>> >>> After system resume, need send extcon uevent to userspace >> >> Why did extcon send uevent after wakeup from suspend? >> >> If extcon cable is attatched or detached on suspend state, >> Kernel can detect the interrupt about changed state of extcon. > > irq controller has lost power in suspend, so there is no pending interrupt. > and HW will not pend any interrupt when we hotplug cable during sleep. No, SoC in suspend state must maintain the minimum power under 1mA if completed the power-optimization on suspend state. If user insert USB cable to target, the external interrupt connected to USB port is happened. And kernel would be waked up from suspend state to operate proper interrupt handler of external interrupt. Also, Input subsystem used gpio-keys driver for power button.. If user press power button in suspend state, target would be waked up from suspend state. It is same case both extcon gpio and gpio-keys of input subsystem. > >> So, kernel would execute proper operation about interrupt >> after wakeup from suspend state. > > kernel only save/restore the register status of gpio, how could it > know whether there is a pending interrupt if the HW doesn't do it? > >> >> I think it isn't necessary. >> >> Thanks, >> Chanwoo Choi >> >>> >>> Change-Id: I32a9e1c6646035f95765bba79a7acaccb8ce45a7 >>> >>> Signed-off-by: Rongjun Ying <rongjun.ying@csr.com> >>> --- >>> drivers/extcon/extcon-gpio.c | 17 +++++++++++++++++ >>> 1 files changed, 17 insertions(+), 0 deletions(-) >>> >>> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c >>> index 7e0dff5..d916522 100644 >>> --- a/drivers/extcon/extcon-gpio.c >>> +++ b/drivers/extcon/extcon-gpio.c >>> @@ -159,12 +159,29 @@ static int gpio_extcon_remove(struct platform_device *pdev) >>> return 0; >>> } >>> >>> +#ifdef CONFIG_PM_SLEEP >>> +static int gpio_extcon_resume(struct device *dev) >>> +{ >>> + struct gpio_extcon_data *extcon_data; >>> + >>> + extcon_data = dev_get_drvdata(dev); >>> + queue_delayed_work(system_power_efficient_wq, &extcon_data->work, >>> + extcon_data->debounce_jiffies); >>> + return 0; >>> +} >>> +#endif >>> + >>> +static const struct dev_pm_ops gpio_extcon_pm_ops = { >>> + SET_SYSTEM_SLEEP_PM_OPS(NULL, gpio_extcon_resume) >>> +}; >>> + >>> static struct platform_driver gpio_extcon_driver = { >>> .probe = gpio_extcon_probe, >>> .remove = gpio_extcon_remove, >>> .driver = { >>> .name = "extcon-gpio", >>> .owner = THIS_MODULE, >>> + .pm = &gpio_extcon_pm_ops, >>> }, >>> }; >>> >>> >> > > -barry > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] extcon: gpio: Add power resume support 2013-12-23 6:34 ` Chanwoo Choi @ 2013-12-23 7:36 ` Barry Song 2013-12-23 7:56 ` Chanwoo Choi 0 siblings, 1 reply; 9+ messages in thread From: Barry Song @ 2013-12-23 7:36 UTC (permalink / raw) To: Chanwoo Choi; +Cc: rjying, MyungJoo Ham, LKML, RongJun Ying, Binghua Duan 2013/12/23 Chanwoo Choi <cw00.choi@samsung.com>: > On 12/23/2013 03:10 PM, Barry Song wrote: >> 2013/12/23 Chanwoo Choi <cw00.choi@samsung.com>: >>> On 12/20/2013 05:09 PM, rjying wrote: >>>> From: Rongjun Ying <rongjun.ying@csr.com> >>>> >>>> After system resume, need send extcon uevent to userspace >>> >>> Why did extcon send uevent after wakeup from suspend? >>> >>> If extcon cable is attatched or detached on suspend state, >>> Kernel can detect the interrupt about changed state of extcon. >> >> irq controller has lost power in suspend, so there is no pending interrupt. >> and HW will not pend any interrupt when we hotplug cable during sleep. > > No, SoC in suspend state must maintain the minimum power under 1mA > if completed the power-optimization on suspend state. > > If user insert USB cable to target, the external interrupt connected to > USB port is happened. And kernel would be waked up from suspend state > to operate proper interrupt handler of external interrupt. no. not every USB supports that. that depends on the power domain design of SoC. > > Also, > Input subsystem used gpio-keys driver for power button.. > If user press power button in suspend state, target would be waked up from suspend state. > It is same case both extcon gpio and gpio-keys of input subsystem. no. it depends on the SoC design. many SoC only support 1 special key which can work as ON-KEY as wakeup source. and this kind of keys might not be GPIO at all. there is a special power domain which is still open for it. > >> >>> So, kernel would execute proper operation about interrupt >>> after wakeup from suspend state. >> >> kernel only save/restore the register status of gpio, how could it >> know whether there is a pending interrupt if the HW doesn't do it? >> >>> >>> I think it isn't necessary. >>> >>> Thanks, >>> Chanwoo Choi >>> >>>> >>>> Change-Id: I32a9e1c6646035f95765bba79a7acaccb8ce45a7 >>>> >>>> Signed-off-by: Rongjun Ying <rongjun.ying@csr.com> >>>> --- >>>> drivers/extcon/extcon-gpio.c | 17 +++++++++++++++++ >>>> 1 files changed, 17 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c >>>> index 7e0dff5..d916522 100644 >>>> --- a/drivers/extcon/extcon-gpio.c >>>> +++ b/drivers/extcon/extcon-gpio.c >>>> @@ -159,12 +159,29 @@ static int gpio_extcon_remove(struct platform_device *pdev) >>>> return 0; >>>> } >>>> >>>> +#ifdef CONFIG_PM_SLEEP >>>> +static int gpio_extcon_resume(struct device *dev) >>>> +{ >>>> + struct gpio_extcon_data *extcon_data; >>>> + >>>> + extcon_data = dev_get_drvdata(dev); >>>> + queue_delayed_work(system_power_efficient_wq, &extcon_data->work, >>>> + extcon_data->debounce_jiffies); >>>> + return 0; >>>> +} >>>> +#endif >>>> + >>>> +static const struct dev_pm_ops gpio_extcon_pm_ops = { >>>> + SET_SYSTEM_SLEEP_PM_OPS(NULL, gpio_extcon_resume) >>>> +}; >>>> + >>>> static struct platform_driver gpio_extcon_driver = { >>>> .probe = gpio_extcon_probe, >>>> .remove = gpio_extcon_remove, >>>> .driver = { >>>> .name = "extcon-gpio", >>>> .owner = THIS_MODULE, >>>> + .pm = &gpio_extcon_pm_ops, >>>> }, >>>> }; >>>> >>>> >>> >> >> -barry -barry ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] extcon: gpio: Add power resume support 2013-12-23 7:36 ` Barry Song @ 2013-12-23 7:56 ` Chanwoo Choi 2013-12-23 8:13 ` Barry Song 0 siblings, 1 reply; 9+ messages in thread From: Chanwoo Choi @ 2013-12-23 7:56 UTC (permalink / raw) To: Barry Song; +Cc: rjying, MyungJoo Ham, LKML, RongJun Ying, Binghua Duan On 12/23/2013 04:36 PM, Barry Song wrote: > 2013/12/23 Chanwoo Choi <cw00.choi@samsung.com>: >> On 12/23/2013 03:10 PM, Barry Song wrote: >>> 2013/12/23 Chanwoo Choi <cw00.choi@samsung.com>: >>>> On 12/20/2013 05:09 PM, rjying wrote: >>>>> From: Rongjun Ying <rongjun.ying@csr.com> >>>>> >>>>> After system resume, need send extcon uevent to userspace >>>> >>>> Why did extcon send uevent after wakeup from suspend? >>>> >>>> If extcon cable is attatched or detached on suspend state, >>>> Kernel can detect the interrupt about changed state of extcon. >>> >>> irq controller has lost power in suspend, so there is no pending interrupt. >>> and HW will not pend any interrupt when we hotplug cable during sleep. >> >> No, SoC in suspend state must maintain the minimum power under 1mA >> if completed the power-optimization on suspend state. >> >> If user insert USB cable to target, the external interrupt connected to >> USB port is happened. And kernel would be waked up from suspend state >> to operate proper interrupt handler of external interrupt. > > no. not every USB supports that. that depends on the power domain design of SoC. USB is only example for gpio control in suspend state. > >> >> Also, >> Input subsystem used gpio-keys driver for power button.. >> If user press power button in suspend state, target would be waked up from suspend state. >> It is same case both extcon gpio and gpio-keys of input subsystem. > > no. it depends on the SoC design. many SoC only support 1 special key > which can work as ON-KEY as wakeup source. and this kind of keys might > not be GPIO at all. > there is a special power domain which is still open for it. many SoC? As I knew, most SoC has supported various wakeup source. As you comment, if specific SoC support only one special key for wakeup from suspend state, I think it isn't common. Also, This patch isn't necessary on SoCs which support various wakeup source (e.g., external interrupt). As you comment, this issue has dependecy on specific SoC. Why did you think this common code? > >> >>> >>>> So, kernel would execute proper operation about interrupt >>>> after wakeup from suspend state. >>> >>> kernel only save/restore the register status of gpio, how could it >>> know whether there is a pending interrupt if the HW doesn't do it? >>> >>>> >>>> I think it isn't necessary. >>>> >>>> Thanks, >>>> Chanwoo Choi >>>> >>>>> >>>>> Change-Id: I32a9e1c6646035f95765bba79a7acaccb8ce45a7 >>>>> >>>>> Signed-off-by: Rongjun Ying <rongjun.ying@csr.com> >>>>> --- >>>>> drivers/extcon/extcon-gpio.c | 17 +++++++++++++++++ >>>>> 1 files changed, 17 insertions(+), 0 deletions(-) >>>>> >>>>> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c >>>>> index 7e0dff5..d916522 100644 >>>>> --- a/drivers/extcon/extcon-gpio.c >>>>> +++ b/drivers/extcon/extcon-gpio.c >>>>> @@ -159,12 +159,29 @@ static int gpio_extcon_remove(struct platform_device *pdev) >>>>> return 0; >>>>> } >>>>> >>>>> +#ifdef CONFIG_PM_SLEEP >>>>> +static int gpio_extcon_resume(struct device *dev) >>>>> +{ >>>>> + struct gpio_extcon_data *extcon_data; >>>>> + >>>>> + extcon_data = dev_get_drvdata(dev); >>>>> + queue_delayed_work(system_power_efficient_wq, &extcon_data->work, >>>>> + extcon_data->debounce_jiffies); >>>>> + return 0; >>>>> +} >>>>> +#endif >>>>> + >>>>> +static const struct dev_pm_ops gpio_extcon_pm_ops = { >>>>> + SET_SYSTEM_SLEEP_PM_OPS(NULL, gpio_extcon_resume) >>>>> +}; >>>>> + >>>>> static struct platform_driver gpio_extcon_driver = { >>>>> .probe = gpio_extcon_probe, >>>>> .remove = gpio_extcon_remove, >>>>> .driver = { >>>>> .name = "extcon-gpio", >>>>> .owner = THIS_MODULE, >>>>> + .pm = &gpio_extcon_pm_ops, >>>>> }, >>>>> }; >>>>> >>>>> >>>> >>> >>> -barry > > -barry > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] extcon: gpio: Add power resume support 2013-12-23 7:56 ` Chanwoo Choi @ 2013-12-23 8:13 ` Barry Song 2013-12-23 8:26 ` Chanwoo Choi 0 siblings, 1 reply; 9+ messages in thread From: Barry Song @ 2013-12-23 8:13 UTC (permalink / raw) To: Chanwoo Choi; +Cc: rjying, MyungJoo Ham, LKML, RongJun Ying, Binghua Duan 2013/12/23 Chanwoo Choi <cw00.choi@samsung.com>: > On 12/23/2013 04:36 PM, Barry Song wrote: >> 2013/12/23 Chanwoo Choi <cw00.choi@samsung.com>: >>> On 12/23/2013 03:10 PM, Barry Song wrote: >>>> 2013/12/23 Chanwoo Choi <cw00.choi@samsung.com>: >>>>> On 12/20/2013 05:09 PM, rjying wrote: >>>>>> From: Rongjun Ying <rongjun.ying@csr.com> >>>>>> >>>>>> After system resume, need send extcon uevent to userspace >>>>> >>>>> Why did extcon send uevent after wakeup from suspend? >>>>> >>>>> If extcon cable is attatched or detached on suspend state, >>>>> Kernel can detect the interrupt about changed state of extcon. >>>> >>>> irq controller has lost power in suspend, so there is no pending interrupt. >>>> and HW will not pend any interrupt when we hotplug cable during sleep. >>> >>> No, SoC in suspend state must maintain the minimum power under 1mA >>> if completed the power-optimization on suspend state. >>> >>> If user insert USB cable to target, the external interrupt connected to >>> USB port is happened. And kernel would be waked up from suspend state >>> to operate proper interrupt handler of external interrupt. >> >> no. not every USB supports that. that depends on the power domain design of SoC. > > USB is only example for gpio control in suspend state. > >> >>> >>> Also, >>> Input subsystem used gpio-keys driver for power button.. >>> If user press power button in suspend state, target would be waked up from suspend state. >>> It is same case both extcon gpio and gpio-keys of input subsystem. >> >> no. it depends on the SoC design. many SoC only support 1 special key >> which can work as ON-KEY as wakeup source. and this kind of keys might >> not be GPIO at all. >> there is a special power domain which is still open for it. > > many SoC? > > As I knew, most SoC has supported various wakeup source. > As you comment, if specific SoC support only one special key > for wakeup from suspend state, I think it isn't common. > > Also, > This patch isn't necessary on SoCs which support various wakeup source (e.g., external interrupt). > As you comment, this issue has dependecy on specific SoC. Why did you think this common code? i am not thinking this patch must be common codes but i think the extcon should provide common codes to support all chips. that is what a framework should consider. if there is no this or things similar with this, how could extcon support the chips which don't support receiving sleep gpio interrupts? > >> >>> >>>> >>>>> So, kernel would execute proper operation about interrupt >>>>> after wakeup from suspend state. >>>> >>>> kernel only save/restore the register status of gpio, how could it >>>> know whether there is a pending interrupt if the HW doesn't do it? >>>> >>>>> >>>>> I think it isn't necessary. >>>>> >>>>> Thanks, >>>>> Chanwoo Choi >>>>> >>>>>> >>>>>> Change-Id: I32a9e1c6646035f95765bba79a7acaccb8ce45a7 >>>>>> >>>>>> Signed-off-by: Rongjun Ying <rongjun.ying@csr.com> >>>>>> --- >>>>>> drivers/extcon/extcon-gpio.c | 17 +++++++++++++++++ >>>>>> 1 files changed, 17 insertions(+), 0 deletions(-) >>>>>> >>>>>> diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c >>>>>> index 7e0dff5..d916522 100644 >>>>>> --- a/drivers/extcon/extcon-gpio.c >>>>>> +++ b/drivers/extcon/extcon-gpio.c >>>>>> @@ -159,12 +159,29 @@ static int gpio_extcon_remove(struct platform_device *pdev) >>>>>> return 0; >>>>>> } >>>>>> >>>>>> +#ifdef CONFIG_PM_SLEEP >>>>>> +static int gpio_extcon_resume(struct device *dev) >>>>>> +{ >>>>>> + struct gpio_extcon_data *extcon_data; >>>>>> + >>>>>> + extcon_data = dev_get_drvdata(dev); >>>>>> + queue_delayed_work(system_power_efficient_wq, &extcon_data->work, >>>>>> + extcon_data->debounce_jiffies); >>>>>> + return 0; >>>>>> +} >>>>>> +#endif >>>>>> + >>>>>> +static const struct dev_pm_ops gpio_extcon_pm_ops = { >>>>>> + SET_SYSTEM_SLEEP_PM_OPS(NULL, gpio_extcon_resume) >>>>>> +}; >>>>>> + >>>>>> static struct platform_driver gpio_extcon_driver = { >>>>>> .probe = gpio_extcon_probe, >>>>>> .remove = gpio_extcon_remove, >>>>>> .driver = { >>>>>> .name = "extcon-gpio", >>>>>> .owner = THIS_MODULE, >>>>>> + .pm = &gpio_extcon_pm_ops, >>>>>> }, >>>>>> }; >>>>>> >>>>>> >>>>> >>>> >>>> -barry >> >> -barry -barry ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] extcon: gpio: Add power resume support 2013-12-23 8:13 ` Barry Song @ 2013-12-23 8:26 ` Chanwoo Choi 2013-12-23 8:35 ` Barry Song 0 siblings, 1 reply; 9+ messages in thread From: Chanwoo Choi @ 2013-12-23 8:26 UTC (permalink / raw) To: Barry Song; +Cc: rjying, MyungJoo Ham, LKML, RongJun Ying, Binghua Duan On 12/23/2013 05:13 PM, Barry Song wrote: > 2013/12/23 Chanwoo Choi <cw00.choi@samsung.com>: >> On 12/23/2013 04:36 PM, Barry Song wrote: >>> 2013/12/23 Chanwoo Choi <cw00.choi@samsung.com>: >>>> On 12/23/2013 03:10 PM, Barry Song wrote: >>>>> 2013/12/23 Chanwoo Choi <cw00.choi@samsung.com>: >>>>>> On 12/20/2013 05:09 PM, rjying wrote: >>>>>>> From: Rongjun Ying <rongjun.ying@csr.com> >>>>>>> >>>>>>> After system resume, need send extcon uevent to userspace >>>>>> >>>>>> Why did extcon send uevent after wakeup from suspend? >>>>>> >>>>>> If extcon cable is attatched or detached on suspend state, >>>>>> Kernel can detect the interrupt about changed state of extcon. >>>>> >>>>> irq controller has lost power in suspend, so there is no pending interrupt. >>>>> and HW will not pend any interrupt when we hotplug cable during sleep. >>>> >>>> No, SoC in suspend state must maintain the minimum power under 1mA >>>> if completed the power-optimization on suspend state. >>>> >>>> If user insert USB cable to target, the external interrupt connected to >>>> USB port is happened. And kernel would be waked up from suspend state >>>> to operate proper interrupt handler of external interrupt. >>> >>> no. not every USB supports that. that depends on the power domain design of SoC. >> >> USB is only example for gpio control in suspend state. >> >>> >>>> >>>> Also, >>>> Input subsystem used gpio-keys driver for power button.. >>>> If user press power button in suspend state, target would be waked up from suspend state. >>>> It is same case both extcon gpio and gpio-keys of input subsystem. >>> >>> no. it depends on the SoC design. many SoC only support 1 special key >>> which can work as ON-KEY as wakeup source. and this kind of keys might >>> not be GPIO at all. >>> there is a special power domain which is still open for it. >> >> many SoC? >> >> As I knew, most SoC has supported various wakeup source. >> As you comment, if specific SoC support only one special key >> for wakeup from suspend state, I think it isn't common. >> >> Also, >> This patch isn't necessary on SoCs which support various wakeup source (e.g., external interrupt). >> As you comment, this issue has dependecy on specific SoC. Why did you think this common code? > > i am not thinking this patch must be common codes but i think the > extcon should provide common codes to support all chips. that is what > a framework should consider. > > if there is no this or things similar with this, how could extcon > support the chips which don't support receiving sleep gpio interrupts? Sure, subsystem should support all cases related to this issue. I'd like to send common patch to support all cases as we discussed. If some patch support all case, I would review and apply it. Chanwoo Choi ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] extcon: gpio: Add power resume support 2013-12-23 8:26 ` Chanwoo Choi @ 2013-12-23 8:35 ` Barry Song 0 siblings, 0 replies; 9+ messages in thread From: Barry Song @ 2013-12-23 8:35 UTC (permalink / raw) To: Chanwoo Choi; +Cc: rjying, MyungJoo Ham, LKML, RongJun Ying, Binghua Duan 2013/12/23 Chanwoo Choi <cw00.choi@samsung.com>: > On 12/23/2013 05:13 PM, Barry Song wrote: >> 2013/12/23 Chanwoo Choi <cw00.choi@samsung.com>: >>> On 12/23/2013 04:36 PM, Barry Song wrote: >>>> 2013/12/23 Chanwoo Choi <cw00.choi@samsung.com>: >>>>> On 12/23/2013 03:10 PM, Barry Song wrote: >>>>>> 2013/12/23 Chanwoo Choi <cw00.choi@samsung.com>: >>>>>>> On 12/20/2013 05:09 PM, rjying wrote: >>>>>>>> From: Rongjun Ying <rongjun.ying@csr.com> >>>>>>>> >>>>>>>> After system resume, need send extcon uevent to userspace >>>>>>> >>>>>>> Why did extcon send uevent after wakeup from suspend? >>>>>>> >>>>>>> If extcon cable is attatched or detached on suspend state, >>>>>>> Kernel can detect the interrupt about changed state of extcon. >>>>>> >>>>>> irq controller has lost power in suspend, so there is no pending interrupt. >>>>>> and HW will not pend any interrupt when we hotplug cable during sleep. >>>>> >>>>> No, SoC in suspend state must maintain the minimum power under 1mA >>>>> if completed the power-optimization on suspend state. >>>>> >>>>> If user insert USB cable to target, the external interrupt connected to >>>>> USB port is happened. And kernel would be waked up from suspend state >>>>> to operate proper interrupt handler of external interrupt. >>>> >>>> no. not every USB supports that. that depends on the power domain design of SoC. >>> >>> USB is only example for gpio control in suspend state. >>> >>>> >>>>> >>>>> Also, >>>>> Input subsystem used gpio-keys driver for power button.. >>>>> If user press power button in suspend state, target would be waked up from suspend state. >>>>> It is same case both extcon gpio and gpio-keys of input subsystem. >>>> >>>> no. it depends on the SoC design. many SoC only support 1 special key >>>> which can work as ON-KEY as wakeup source. and this kind of keys might >>>> not be GPIO at all. >>>> there is a special power domain which is still open for it. >>> >>> many SoC? >>> >>> As I knew, most SoC has supported various wakeup source. >>> As you comment, if specific SoC support only one special key >>> for wakeup from suspend state, I think it isn't common. >>> >>> Also, >>> This patch isn't necessary on SoCs which support various wakeup source (e.g., external interrupt). >>> As you comment, this issue has dependecy on specific SoC. Why did you think this common code? >> >> i am not thinking this patch must be common codes but i think the >> extcon should provide common codes to support all chips. that is what >> a framework should consider. >> >> if there is no this or things similar with this, how could extcon >> support the chips which don't support receiving sleep gpio interrupts? > > Sure, subsystem should support all cases related to this issue. > > I'd like to send common patch to support all cases as we discussed. > If some patch support all case, I would review and apply it. well. agree. then, will you give comments about how to make this one common? will it be useful to differentiate two different kinds of chips and branch to two different code paths? > > Chanwoo Choi > > -barry ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-12-23 8:35 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-12-20 8:09 [PATCH 1/1] extcon: gpio: Add power resume support rjying 2013-12-23 4:20 ` Chanwoo Choi 2013-12-23 6:10 ` Barry Song 2013-12-23 6:34 ` Chanwoo Choi 2013-12-23 7:36 ` Barry Song 2013-12-23 7:56 ` Chanwoo Choi 2013-12-23 8:13 ` Barry Song 2013-12-23 8:26 ` Chanwoo Choi 2013-12-23 8:35 ` Barry Song
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox