From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751987Ab3LXMag (ORCPT ); Tue, 24 Dec 2013 07:30:36 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:46659 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750974Ab3LXMae (ORCPT ); Tue, 24 Dec 2013 07:30:34 -0500 Message-ID: <52B98BBC.9060909@ti.com> Date: Tue, 24 Dec 2013 15:27:24 +0200 From: Grygorii Strashko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Prabhakar Lad CC: Santosh Shilimkar , Sekhar Nori , Rob Herring , dlos , "linux-gpio@vger.kernel.org" , LAK , LKML , Alexandre Courbot , "devicetree@vger.kernel.org" Subject: Re: [PATCH v3 2/2] gpio: davinci: reuse for Keystone SoC References: <1387885284-8119-1-git-send-email-grygorii.strashko@ti.com> <1387885284-8119-3-git-send-email-grygorii.strashko@ti.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.145.75] X-EXCLAIMER-MD-CONFIG: f9c360f5-3d1e-4c3c-8703-f45bf52eff6b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/24/2013 01:20 PM, Prabhakar Lad wrote: > Hi Grygorii, > > Thanks for the patch. > > On Tue, Dec 24, 2013 at 5:11 PM, Grygorii Strashko > wrote: >> The similar GPIO HW block is used by keystone SoCs as >> in Davinci SoCs. >> Hence, reuse Davinci GPIO driver for Keystone taking into >> account that Keystone contains ARM GIC IRQ controller which >> is implemented using IRQ Chip. >> >> Documentation: >> http://www.ti.com/lit/ug/sprugv1/sprugv1.pdf >> >> Cc: Alexandre Courbot >> Cc: Sekhar Nori >> Cc: devicetree@vger.kernel.org >> >> Acked-by: Santosh Shilimkar >> Acked-by: Linus Walleij >> Signed-off-by: Grygorii Strashko >> --- >> .../devicetree/bindings/gpio/gpio-davinci.txt | 4 +- >> drivers/gpio/gpio-davinci.c | 48 ++++++++++++++++---- >> 2 files changed, 42 insertions(+), 10 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >> index a2e839d..4ce9862 100644 >> --- a/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >> +++ b/Documentation/devicetree/bindings/gpio/gpio-davinci.txt >> @@ -1,7 +1,7 @@ >> -Davinci GPIO controller bindings >> +Davinci/Keystone GPIO controller bindings >> >> Required Properties: >> -- compatible: should be "ti,dm6441-gpio" >> +- compatible: should be "ti,dm6441-gpio", "ti,keystone-gpio" > > Can you make it something like this ? It isn't readable. > > - compatible : value should be either one among the following > (a) "ti,dm6441-gpio" for davinci. > (b) "ti,keystone-gpio" for keystone. > >> >> - reg: Physical base address of the controller and the size of memory mapped >> registers. >> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c >> index 7629b4f..d0f135d 100644 >> --- a/drivers/gpio/gpio-davinci.c >> +++ b/drivers/gpio/gpio-davinci.c >> @@ -37,6 +37,8 @@ struct davinci_gpio_regs { >> u32 intstat; >> }; >> >> +typedef struct irq_chip *(*gpio_get_irq_chip_cb_t)(unsigned int irq); >> + >> #define BINTEN 0x8 /* GPIO Interrupt Per-Bank Enable Register */ >> >> #define chip2controller(chip) \ >> @@ -413,6 +415,26 @@ static const struct irq_domain_ops davinci_gpio_irq_ops = { >> .xlate = irq_domain_xlate_onetwocell, >> }; >> >> +static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq) >> +{ >> + static struct irq_chip_type gpio_unbanked; >> + >> + gpio_unbanked = *container_of(irq_get_chip(irq), >> + struct irq_chip_type, chip); >> + >> + return &gpio_unbanked.chip; >> +}; >> + >> +static struct irq_chip *keystone_gpio_get_irq_chip(unsigned int irq) >> +{ >> + static struct irq_chip gpio_unbanked; >> + >> + gpio_unbanked = *irq_get_chip(irq); >> + return &gpio_unbanked; >> +}; >> + >> +static const struct of_device_id davinci_gpio_ids[]; >> + >> /* >> * NOTE: for suspend/resume, probably best to make a platform_device with >> * suspend_late/resume_resume calls hooking into results of the set_wake() >> @@ -433,6 +455,18 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev) >> struct davinci_gpio_platform_data *pdata = dev->platform_data; >> struct davinci_gpio_regs __iomem *g; >> struct irq_domain *irq_domain = NULL; >> + const struct of_device_id *match; >> + struct irq_chip *irq_chip; >> + gpio_get_irq_chip_cb_t gpio_get_irq_chip; >> + >> + /* >> + * Use davinci_gpio_get_irq_chip by default to handle non DT cases >> + */ >> + gpio_get_irq_chip = davinci_gpio_get_irq_chip; >> + match = of_match_device(of_match_ptr(davinci_gpio_ids), >> + dev); > > Sorry didn't notice that earlier the data structure of_match_ptr() > protects is always compiled in. > so of_match_ptr() is not needed. > While you are at it you can also fix it in davinci_gpio_driver > structure as a sperate > patch. > Not sure. davinci_gpio_ids defined as: #if IS_ENABLED(CONFIG_OF) static const struct of_device_id davinci_gpio_ids[] = { And seems, Davinci may still be compiled without OF enabled. Regards, - grygorii