From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752007Ab3LYKzD (ORCPT ); Wed, 25 Dec 2013 05:55:03 -0500 Received: from mail-la0-f49.google.com ([209.85.215.49]:43211 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751845Ab3LYKy7 (ORCPT ); Wed, 25 Dec 2013 05:54:59 -0500 Message-ID: <52BAB983.3090201@cogentembedded.com> Date: Wed, 25 Dec 2013 14:54:59 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Ding Tianhong , Rupesh Gujare , Greg Kroah-Hartman , devel@driverdev.osuosl.org, Netdev , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 08/19] ozwpan: slight optimization of addr compare References: <52BA50E9.1080203@huawei.com> In-Reply-To: <52BA50E9.1080203@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 25-12-2013 7:28, Ding Tianhong wrote: > Use possibly more efficient ether_addr_equal > instead of memcmp. > Cc: Rupesh Gujare > Cc: Greg Kroah-Hartman > Cc: devel@driverdev.osuosl.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Tan Xiaojun > Signed-off-by: Ding Tianhong > --- > drivers/staging/ozwpan/ozcdev.c | 2 +- > drivers/staging/ozwpan/ozproto.c | 5 +++-- > 2 files changed, 4 insertions(+), 3 deletions(-) > diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c > index 6ce0af9..c363f66 100644 > --- a/drivers/staging/ozwpan/ozcdev.c > +++ b/drivers/staging/ozwpan/ozcdev.c > @@ -448,7 +448,7 @@ int oz_cdev_start(struct oz_pd *pd, int resume) > } > spin_lock(&g_cdev.lock); > if ((g_cdev.active_pd == NULL) && > - (memcmp(pd->mac_addr, g_cdev.active_addr, ETH_ALEN) == 0)) { > + (ether_addr_equal(pd->mac_addr, g_cdev.active_addr))) { There's no point in enclosing function call into parens. WBR, Sergei