From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752977Ab3LZNoB (ORCPT ); Thu, 26 Dec 2013 08:44:01 -0500 Received: from mail-qe0-f50.google.com ([209.85.128.50]:62059 "EHLO mail-qe0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752736Ab3LZNn7 (ORCPT ); Thu, 26 Dec 2013 08:43:59 -0500 Message-ID: <52BC3295.3020007@gmail.com> Date: Thu, 26 Dec 2013 08:43:49 -0500 From: David Ahern User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: acme@ghostprotocols.net, linux-kernel@vger.kernel.org CC: David Ahern , Masami Hiramatsu , Srikar Dronamraju Subject: Re: [PATCH] perf probe: Improve error message when function not found References: <1387562649-25929-1-git-send-email-dsahern@gmail.com> In-Reply-To: <1387562649-25929-1-git-send-email-dsahern@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Masami: If you do not have any problems with this version please Ack so Arnaldo will pick it up. Thanks, David On 12/20/13, 1:04 PM, David Ahern wrote: > When requesting a function from a userspace library the error message to > the user is less than helpful. e.g., > > perf probe -x /lib64/libpthread-2.14.90.so -a 'lock_full=__pthread_mutex_lock_full' > no symbols found in /lib64/libpthread-2.14.90.so, maybe install a debug package? > Failed to load map. > Error: Failed to add events. (-22) > > yet the symbol really does exist but is a local symbol which is filtered: > > nm /lib64/libpthread-2.14.90.so | grep __pthread_mutex_lock_full > 0000000000005700 t __pthread_mutex_lock_full > > With this patch: > perf probe -x /lib64/libpthread-2.14.90.so -a 'lock_full=__pthread_mutex_lock_full' > > no symbols found in /lib64/libpthread-2.14.90.so, maybe install a debug package? > Failed to find function in /lib64/libpthread-2.14.90.so. Perhaps it is a local variable? > Error: Failed to add events. (-22) > > Signed-off-by: David Ahern > Cc: Masami Hiramatsu > Cc: Srikar Dronamraju > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index 9c6989ca2bea..2eac49096840 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -2309,7 +2309,8 @@ static int convert_name_to_addr(struct perf_probe_event *pev, const char *exec) > } > available_func_filter = strfilter__new(function, NULL); > if (map__load(map, filter_available_functions)) { > - pr_err("Failed to load map.\n"); > + pr_err("Failed to find requested symbol in %s. Is it a global variable?\n", > + name); > goto out; > } > >