Re: [PATCH -tip v2 1/2] [CLEANUP] perf-probe: Expand given path to absolute path

David Ahern
2013-12-26T14:14:51Z

On 12/26/13, 12:41 AM, Masami Hiramatsu wrote:
> @@ -180,7 +181,20 @@ static int opt_set_target(const struct option *opt, const char *str,
> else
> return ret;
>
> - params.target = str;
> + /* Expand given path to absolute path, except for modulename */
> + if (params.uprobes || strchr(str, '/')) {
> + tmp = realpath(str, NULL);
> + if (!tmp) {
> + pr_warning("Failed to find the path of %s.\n",
> + str);

That error message will be misleading if it is generated. How about:
Failed to get the absolute path of %s: %d\n", str, errno.

> + return ret;
> + }
> + } else {
> + tmp = strdup(str);
> + if (!tmp)
> + return -ENOMEM;
> + }
> + params.target = tmp;

When is params.target freed?

David