From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750787Ab3L1FGZ (ORCPT ); Sat, 28 Dec 2013 00:06:25 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:7156 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750705Ab3L1FGY (ORCPT ); Sat, 28 Dec 2013 00:06:24 -0500 Message-ID: <52BE5C2D.1030602@huawei.com> Date: Sat, 28 Dec 2013 13:05:49 +0800 From: Ding Tianhong User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Eric Dumazet CC: "David S. Miller" , Netdev , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next 19/20] net: plip: slight optimization of addr compare References: <52BD22ED.4030302@huawei.com> <1388159283.12212.80.camel@edumazet-glaptop2.roam.corp.google.com> In-Reply-To: <1388159283.12212.80.camel@edumazet-glaptop2.roam.corp.google.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.135.72.199] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2013/12/27 23:48, Eric Dumazet wrote: > On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote: >> Use possibly more efficient ether_addr_equal >> to instead of memcmp. >> >> Cc: "David S. Miller" >> Signed-off-by: Ding Tianhong >> --- >> drivers/net/plip/plip.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/plip/plip.c b/drivers/net/plip/plip.c >> index 7b4ff35..26614df 100644 >> --- a/drivers/net/plip/plip.c >> +++ b/drivers/net/plip/plip.c >> @@ -549,7 +549,7 @@ static __be16 plip_type_trans(struct sk_buff *skb, struct net_device *dev) >> >> if(*eth->h_dest&1) >> { >> - if(memcmp(eth->h_dest,dev->broadcast, ETH_ALEN)==0) >> + if(ether_addr_equal(eth->h_dest, dev->broadcast)) >> skb->pkt_type=PACKET_BROADCAST; >> else >> skb->pkt_type=PACKET_MULTICAST; > > What about : > > if (is_multicast_ether_addr(eth->h_dest)) { > if (ether_addr_equal_64bits(eth->h_dest, dev->broadcast)) > skb->pkt_type = PACKET_BROADCAST; > else > skb->pkt_type = PACKET_MULTICAST; > } > > > more better, thanks. Regards Ding > >