From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755439Ab3L1N6N (ORCPT ); Sat, 28 Dec 2013 08:58:13 -0500 Received: from mail-la0-f41.google.com ([209.85.215.41]:44570 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755369Ab3L1N6L (ORCPT ); Sat, 28 Dec 2013 08:58:11 -0500 Message-ID: <52BED8ED.2040908@cogentembedded.com> Date: Sat, 28 Dec 2013 17:58:05 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Ding Tianhong , "David S. Miller" , Netdev , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net-next v2 11/20] net: packetengines: slight optimization of addr References: <52BE6D0D.9050301@huawei.com> In-Reply-To: <52BE6D0D.9050301@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 28-12-2013 10:17, Ding Tianhong wrote: > Use possibly more efficient ether_addr_equal > to instead of memcmp. > Cc: "David S. Miller" > Signed-off-by: Ding Tianhong > --- > drivers/net/ethernet/packetengines/yellowfin.c | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > diff --git a/drivers/net/ethernet/packetengines/yellowfin.c b/drivers/net/ethernet/packetengines/yellowfin.c > index d28593b..b83ac0e 100644 > --- a/drivers/net/ethernet/packetengines/yellowfin.c > +++ b/drivers/net/ethernet/packetengines/yellowfin.c > @@ -1097,12 +1097,12 @@ static int yellowfin_rx(struct net_device *dev) > if (status2 & 0x80) dev->stats.rx_dropped++; > #ifdef YF_PROTOTYPE /* Support for prototype hardware errata. */ > } else if ((yp->flags & HasMACAddrBug) && > - memcmp(le32_to_cpu(yp->rx_ring_dma + > - entry*sizeof(struct yellowfin_desc)), > - dev->dev_addr, 6) != 0 && > - memcmp(le32_to_cpu(yp->rx_ring_dma + > - entry*sizeof(struct yellowfin_desc)), > - "\377\377\377\377\377\377", 6) != 0) { > + !ether_addr_equal(le32_to_cpu(yp->rx_ring_dma + > + entry * sizeof(struct yellowfin_desc)), > + dev->dev_addr) && Previous line was aligned correctly, the above line should start under le32_to_cpu. > + !ether_addr_equal(le32_to_cpu(yp->rx_ring_dma + > + entry * sizeof(struct yellowfin_desc)), Start the continuation lines under 'yp', please. > + "\377\377\377\377\377\377")) { This line should start under le32_to_cpu. WBR, Sergei