public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* KCONFIG_ALLCONFIG + allmodconfig = brokenness
@ 2013-12-30  1:32 H. Peter Anvin
  2013-12-30  2:22 ` Randy Dunlap
  0 siblings, 1 reply; 4+ messages in thread
From: H. Peter Anvin @ 2013-12-30  1:32 UTC (permalink / raw)
  To: linux-kbuild, Linux Kernel Mailing List

When KCONFIG_ALLCONFIG is used with "make allmodconfig", the result ends
up being largely the same as "make allyesconfig", because the resulting
kernel ends up with CONFIG_MODULES=n:

How to reproduce:

: tazenda 125 ; make O=../o.test allmodconfig
  GEN     /home/hpa/kernel/o.test/Makefile
scripts/kconfig/conf --allmodconfig Kconfig
#
# configuration written to .config
#
: tazenda 126 ; grep CONFIG_MODULES ../o.test/.config
CONFIG_MODULES_USE_ELF_RELA=y
CONFIG_MODULES=y
: tazenda 127 ; env KCONFIG_ALLCONFIG=/dev/null make O=../o.test
allmodconfig
  GEN     /home/hpa/kernel/o.test/Makefile
scripts/kconfig/conf --allmodconfig Kconfig
#
# configuration written to .config
#
: tazenda 128 ; grep CONFIG_MODULES ../o.test/.config
CONFIG_MODULES_USE_ELF_RELA=y
# CONFIG_MODULES is not set

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: KCONFIG_ALLCONFIG + allmodconfig = brokenness
  2013-12-30  1:32 KCONFIG_ALLCONFIG + allmodconfig = brokenness H. Peter Anvin
@ 2013-12-30  2:22 ` Randy Dunlap
  2013-12-30  2:30   ` Randy Dunlap
  0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2013-12-30  2:22 UTC (permalink / raw)
  To: H. Peter Anvin, linux-kbuild, Linux Kernel Mailing List

On 12/29/13 17:32, H. Peter Anvin wrote:
> When KCONFIG_ALLCONFIG is used with "make allmodconfig", the result ends
> up being largely the same as "make allyesconfig", because the resulting
> kernel ends up with CONFIG_MODULES=n:
> 
> How to reproduce:
> 
> : tazenda 125 ; make O=../o.test allmodconfig
>   GEN     /home/hpa/kernel/o.test/Makefile
> scripts/kconfig/conf --allmodconfig Kconfig
> #
> # configuration written to .config
> #
> : tazenda 126 ; grep CONFIG_MODULES ../o.test/.config
> CONFIG_MODULES_USE_ELF_RELA=y
> CONFIG_MODULES=y
> : tazenda 127 ; env KCONFIG_ALLCONFIG=/dev/null make O=../o.test
> allmodconfig
>   GEN     /home/hpa/kernel/o.test/Makefile
> scripts/kconfig/conf --allmodconfig Kconfig
> #
> # configuration written to .config
> #
> : tazenda 128 ; grep CONFIG_MODULES ../o.test/.config
> CONFIG_MODULES_USE_ELF_RELA=y
> # CONFIG_MODULES is not set
> --

Yes, I discovered this a few weeks ago.
I just ended up adding
CONFIG_MODULES=y
to my KCONFIG_ALLCONFIG file.

There was a comment in the git commit for it about this (that I discovered
during my "research" into it), but I can't find it just now.

I wasn't fond of the change either.


-- 
~Randy

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: KCONFIG_ALLCONFIG + allmodconfig = brokenness
  2013-12-30  2:22 ` Randy Dunlap
@ 2013-12-30  2:30   ` Randy Dunlap
  2013-12-30  3:58     ` H. Peter Anvin
  0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2013-12-30  2:30 UTC (permalink / raw)
  To: H. Peter Anvin, linux-kbuild, Linux Kernel Mailing List

On 12/29/13 18:22, Randy Dunlap wrote:
> On 12/29/13 17:32, H. Peter Anvin wrote:
>> When KCONFIG_ALLCONFIG is used with "make allmodconfig", the result ends
>> up being largely the same as "make allyesconfig", because the resulting
>> kernel ends up with CONFIG_MODULES=n:
>>
>> How to reproduce:
>>
>> : tazenda 125 ; make O=../o.test allmodconfig
>>   GEN     /home/hpa/kernel/o.test/Makefile
>> scripts/kconfig/conf --allmodconfig Kconfig
>> #
>> # configuration written to .config
>> #
>> : tazenda 126 ; grep CONFIG_MODULES ../o.test/.config
>> CONFIG_MODULES_USE_ELF_RELA=y
>> CONFIG_MODULES=y
>> : tazenda 127 ; env KCONFIG_ALLCONFIG=/dev/null make O=../o.test
>> allmodconfig
>>   GEN     /home/hpa/kernel/o.test/Makefile
>> scripts/kconfig/conf --allmodconfig Kconfig
>> #
>> # configuration written to .config
>> #
>> : tazenda 128 ; grep CONFIG_MODULES ../o.test/.config
>> CONFIG_MODULES_USE_ELF_RELA=y
>> # CONFIG_MODULES is not set
>> --
> 
> Yes, I discovered this a few weeks ago.
> I just ended up adding
> CONFIG_MODULES=y
> to my KCONFIG_ALLCONFIG file.
> 
> There was a comment in the git commit for it about this (that I discovered
> during my "research" into it), but I can't find it just now.

See 11097a0367e48954ecf616f9b0df48d86835dd0d.

> I wasn't fond of the change either.
> 
> 


-- 
~Randy

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: KCONFIG_ALLCONFIG + allmodconfig = brokenness
  2013-12-30  2:30   ` Randy Dunlap
@ 2013-12-30  3:58     ` H. Peter Anvin
  0 siblings, 0 replies; 4+ messages in thread
From: H. Peter Anvin @ 2013-12-30  3:58 UTC (permalink / raw)
  To: Randy Dunlap, linux-kbuild, Linux Kernel Mailing List

On 12/29/2013 06:30 PM, Randy Dunlap wrote:
>>
>> Yes, I discovered this a few weeks ago.
>> I just ended up adding
>> CONFIG_MODULES=y
>> to my KCONFIG_ALLCONFIG file.
>>

Yes, I'm using the same workaround now.  It works for me, since I keep
an override file anyway.

	-hpa



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-12-30  3:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-30  1:32 KCONFIG_ALLCONFIG + allmodconfig = brokenness H. Peter Anvin
2013-12-30  2:22 ` Randy Dunlap
2013-12-30  2:30   ` Randy Dunlap
2013-12-30  3:58     ` H. Peter Anvin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox