public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: "H. Peter Anvin" <hpa@zytor.com>,
	linux-kbuild@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: KCONFIG_ALLCONFIG + allmodconfig = brokenness
Date: Sun, 29 Dec 2013 18:22:26 -0800	[thread overview]
Message-ID: <52C0D8E2.7050101@infradead.org> (raw)
In-Reply-To: <52C0CD3F.7080808@zytor.com>

On 12/29/13 17:32, H. Peter Anvin wrote:
> When KCONFIG_ALLCONFIG is used with "make allmodconfig", the result ends
> up being largely the same as "make allyesconfig", because the resulting
> kernel ends up with CONFIG_MODULES=n:
> 
> How to reproduce:
> 
> : tazenda 125 ; make O=../o.test allmodconfig
>   GEN     /home/hpa/kernel/o.test/Makefile
> scripts/kconfig/conf --allmodconfig Kconfig
> #
> # configuration written to .config
> #
> : tazenda 126 ; grep CONFIG_MODULES ../o.test/.config
> CONFIG_MODULES_USE_ELF_RELA=y
> CONFIG_MODULES=y
> : tazenda 127 ; env KCONFIG_ALLCONFIG=/dev/null make O=../o.test
> allmodconfig
>   GEN     /home/hpa/kernel/o.test/Makefile
> scripts/kconfig/conf --allmodconfig Kconfig
> #
> # configuration written to .config
> #
> : tazenda 128 ; grep CONFIG_MODULES ../o.test/.config
> CONFIG_MODULES_USE_ELF_RELA=y
> # CONFIG_MODULES is not set
> --

Yes, I discovered this a few weeks ago.
I just ended up adding
CONFIG_MODULES=y
to my KCONFIG_ALLCONFIG file.

There was a comment in the git commit for it about this (that I discovered
during my "research" into it), but I can't find it just now.

I wasn't fond of the change either.


-- 
~Randy

  reply	other threads:[~2013-12-30  2:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-30  1:32 KCONFIG_ALLCONFIG + allmodconfig = brokenness H. Peter Anvin
2013-12-30  2:22 ` Randy Dunlap [this message]
2013-12-30  2:30   ` Randy Dunlap
2013-12-30  3:58     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52C0D8E2.7050101@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=hpa@zytor.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox