From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753478Ab3L3CaN (ORCPT ); Sun, 29 Dec 2013 21:30:13 -0500 Received: from merlin.infradead.org ([205.233.59.134]:55123 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753119Ab3L3CaL (ORCPT ); Sun, 29 Dec 2013 21:30:11 -0500 Message-ID: <52C0DAB2.7090001@infradead.org> Date: Sun, 29 Dec 2013 18:30:10 -0800 From: Randy Dunlap User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: "H. Peter Anvin" , linux-kbuild@vger.kernel.org, Linux Kernel Mailing List Subject: Re: KCONFIG_ALLCONFIG + allmodconfig = brokenness References: <52C0CD3F.7080808@zytor.com> <52C0D8E2.7050101@infradead.org> In-Reply-To: <52C0D8E2.7050101@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/29/13 18:22, Randy Dunlap wrote: > On 12/29/13 17:32, H. Peter Anvin wrote: >> When KCONFIG_ALLCONFIG is used with "make allmodconfig", the result ends >> up being largely the same as "make allyesconfig", because the resulting >> kernel ends up with CONFIG_MODULES=n: >> >> How to reproduce: >> >> : tazenda 125 ; make O=../o.test allmodconfig >> GEN /home/hpa/kernel/o.test/Makefile >> scripts/kconfig/conf --allmodconfig Kconfig >> # >> # configuration written to .config >> # >> : tazenda 126 ; grep CONFIG_MODULES ../o.test/.config >> CONFIG_MODULES_USE_ELF_RELA=y >> CONFIG_MODULES=y >> : tazenda 127 ; env KCONFIG_ALLCONFIG=/dev/null make O=../o.test >> allmodconfig >> GEN /home/hpa/kernel/o.test/Makefile >> scripts/kconfig/conf --allmodconfig Kconfig >> # >> # configuration written to .config >> # >> : tazenda 128 ; grep CONFIG_MODULES ../o.test/.config >> CONFIG_MODULES_USE_ELF_RELA=y >> # CONFIG_MODULES is not set >> -- > > Yes, I discovered this a few weeks ago. > I just ended up adding > CONFIG_MODULES=y > to my KCONFIG_ALLCONFIG file. > > There was a comment in the git commit for it about this (that I discovered > during my "research" into it), but I can't find it just now. See 11097a0367e48954ecf616f9b0df48d86835dd0d. > I wasn't fond of the change either. > > -- ~Randy