From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751501Ab3L3G7n (ORCPT ); Mon, 30 Dec 2013 01:59:43 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:51430 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751270Ab3L3G7l (ORCPT ); Mon, 30 Dec 2013 01:59:41 -0500 Message-ID: <52C119B4.1010002@ti.com> Date: Mon, 30 Dec 2013 12:29:00 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Yuvaraj Kumar C D CC: , , , , , , , , , , , , , , , Yuvaraj Kumar C D Subject: Re: [PATCH V3 2/2] ARM: dts: Enable ahci sata and sata phy References: <1386669911-17319-1-git-send-email-yuvaraj.cd@samsung.com> <1386669911-17319-3-git-send-email-yuvaraj.cd@samsung.com> In-Reply-To: <1386669911-17319-3-git-send-email-yuvaraj.cd@samsung.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday 10 December 2013 03:35 PM, Yuvaraj Kumar C D wrote: > This patch adds dt entry for ahci sata controller and its > corresponding phy controller.phy node has been added w.r.t > new generic phy framework. > > Changes since V2: > 1.Used syscon interface to PMU handling. > 2.Changed "sata-phy-i2c" to "exynos-sataphy-i2c". > > Changes since V1: > 1.Minor changes to node name convention. > 2.Updated binding document. Change history should be moved after '---'. > > Signed-off-by: Yuvaraj Kumar C D > --- > .../devicetree/bindings/ata/exynos-sata-phy.txt | 19 ++++++++++++++----- > .../devicetree/bindings/ata/exynos-sata.txt | 17 ++++++++++++----- > .../devicetree/bindings/ata/exynos_sataphy_i2c.txt | 12 ++++++++++++ > arch/arm/boot/dts/exynos5250-arndale.dts | 9 ++++++++- > arch/arm/boot/dts/exynos5250-smdk5250.dts | 8 ++------ > arch/arm/boot/dts/exynos5250.dtsi | 16 ++++++++++++---- > 6 files changed, 60 insertions(+), 21 deletions(-) > create mode 100644 Documentation/devicetree/bindings/ata/exynos_sataphy_i2c.txt > > diff --git a/Documentation/devicetree/bindings/ata/exynos-sata-phy.txt b/Documentation/devicetree/bindings/ata/exynos-sata-phy.txt > index 37824fa..a679e17 100644 > --- a/Documentation/devicetree/bindings/ata/exynos-sata-phy.txt > +++ b/Documentation/devicetree/bindings/ata/exynos-sata-phy.txt IMO this documentation should be in Documentation/devicetree/bindings/phy and you could also use the existing exynos file. > @@ -4,11 +4,20 @@ SATA PHY nodes are defined to describe on-chip SATA Physical layer controllers. > Each SATA PHY controller should have its own node. > > Required properties: > -- compatible : compatible list, contains "samsung,exynos5-sata-phy" > +- compatible : compatible list, contains "samsung,exynos5250-sata-phy" > - reg : > > Example: > - sata@ffe07000 { > - compatible = "samsung,exynos5-sata-phy"; > - reg = <0xffe07000 0x1000>; > - }; > + sata_phy: sata-phy@12170000 { > + compatible = "samsung,exynos5250-sata-phy"; > + reg = <0x12170000 0x1ff>; > + clocks = <&clock 287>; > + clock-names = "sata_phyctrl"; > + #phy-cells = <0>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + sataphy-pmu { > + reg = <0x10040724 0x4>; > + }; alignment problem.. > + }; > diff --git a/Documentation/devicetree/bindings/ata/exynos-sata.txt b/Documentation/devicetree/bindings/ata/exynos-sata.txt > index 0849f10..918bff8 100644 > --- a/Documentation/devicetree/bindings/ata/exynos-sata.txt > +++ b/Documentation/devicetree/bindings/ata/exynos-sata.txt > @@ -8,10 +8,17 @@ Required properties: > - interrupts : > - reg : > - samsung,sata-freq : > +- phys : as mentioned in phy-bindings.txt > +- phy-names : as mentioned in phy-bindings.txt here too.. match it with existing properties.. > > Example: > - sata@ffe08000 { > - compatible = "samsung,exynos5-sata"; > - reg = <0xffe08000 0x1000>; > - interrupts = <115>; > - }; > + sata@122f0000 { > + compatible = "snps,dwc-ahci"; > + samsung,sata-freq = <66>; > + reg = <0x122f0000 0x1ff>; > + interrupts = <0 115 0>; > + clocks = <&clock 277>, <&clock 143>; > + clock-names = "sata", "sclk_sata"; > + phys = <&sata_phy>; > + phy-names = "sata-phy"; > + }; > diff --git a/Documentation/devicetree/bindings/ata/exynos_sataphy_i2c.txt b/Documentation/devicetree/bindings/ata/exynos_sataphy_i2c.txt > new file mode 100644 > index 0000000..deabba9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/ata/exynos_sataphy_i2c.txt This should also be in /bindings/phy.. Cheers Kishon