From: David Vrabel <david.vrabel@citrix.com>
To: Levente Kurusa <levex@linux.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Vrabel <david.vrabel@citrix.com>,
<xen-devel@lists.xenproject.org>,
Andrew Morton <akpm@linux-foundation.org>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [Xen-devel] [PATCH 26/38] xen: xenbus: add missing put_device call
Date: Thu, 2 Jan 2014 13:53:07 +0000 [thread overview]
Message-ID: <52C56F43.6030804@citrix.com> (raw)
In-Reply-To: <1387465429-3568-27-git-send-email-levex@linux.com>
On 19/12/13 15:03, Levente Kurusa wrote:
> This is required so that we give up the last reference to the device.
>
> Signed-off-by: Levente Kurusa <levex@linux.com>
> ---
> drivers/xen/xenbus/xenbus_probe.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/xen/xenbus/xenbus_probe.c b/drivers/xen/xenbus/xenbus_probe.c
> index 3c0a74b..4abb9ee 100644
> --- a/drivers/xen/xenbus/xenbus_probe.c
> +++ b/drivers/xen/xenbus/xenbus_probe.c
> @@ -465,8 +465,10 @@ int xenbus_probe_node(struct xen_bus_type *bus,
>
> /* Register with generic device framework. */
> err = device_register(&xendev->dev);
> - if (err)
> + if (err) {
> + put_device(&xendev->dev);
> goto fail;
> + }
>
> return 0;
> fail:
There is a kfree(xendev) here so this introduces a double-free.
David
next prev parent reply other threads:[~2014-01-02 13:53 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 15:03 [PATCH 01/38] sh: dma-sysfs: add missing put_device call Levente Kurusa
2013-12-19 15:03 ` [PATCH 02/38] powerpc: qe_lib: " Levente Kurusa
2013-12-19 15:03 ` [PATCH 03/38] powerpc: cell: " Levente Kurusa
2013-12-19 15:03 ` [PATCH 04/38] powerpc: kernel: " Levente Kurusa
2013-12-19 15:03 ` [PATCH 05/38] sparc: " Levente Kurusa
2013-12-27 17:43 ` David Miller
2013-12-19 15:03 ` [PATCH 06/38] arm: mach-s3c64: " Levente Kurusa
2013-12-19 15:03 ` [PATCH 07/38] arm: locomo: " Levente Kurusa
2013-12-19 15:03 ` [PATCH 08/38] arm: mach-rpc: " Levente Kurusa
2013-12-19 15:03 ` [PATCH 09/38] arm: mach-imx: add missing put_device calls Levente Kurusa
2013-12-19 15:03 ` [PATCH 10/38] arm: exynos: add missing put_device call Levente Kurusa
2013-12-19 15:03 ` [PATCH 11/38] arm: mach-integrator: " Levente Kurusa
2013-12-19 15:03 ` [PATCH 12/38] arm: s5pv210: " Levente Kurusa
2013-12-19 15:03 ` [PATCH 13/38] arm: s390: " Levente Kurusa
2013-12-19 15:03 ` [PATCH 14/38] mips: txx9: " Levente Kurusa
2013-12-19 15:03 ` [PATCH 15/38] mips: txx9: 7segled: " Levente Kurusa
2013-12-19 15:03 ` [PATCH 16/38] mips: sgi-ip22: " Levente Kurusa
2013-12-19 15:03 ` [PATCH 17/38] parisc: kernel: " Levente Kurusa
2013-12-19 15:29 ` James Bottomley
2013-12-19 15:03 ` [PATCH 18/38] ia64: " Levente Kurusa
2013-12-19 15:03 ` [PATCH 19/38] net: atm: " Levente Kurusa
2013-12-27 17:40 ` David Miller
2013-12-19 15:03 ` [PATCH 20/38] net: iucv: " Levente Kurusa
2013-12-27 17:41 ` David Miller
2013-12-19 15:03 ` [PATCH 21/38] workqueue: " Levente Kurusa
2013-12-19 15:20 ` Tejun Heo
2013-12-19 15:31 ` Levente Kurusa
2013-12-19 15:34 ` Tejun Heo
2013-12-19 15:42 ` Levente Kurusa
2013-12-19 15:45 ` Tejun Heo
2013-12-19 15:03 ` [PATCH 22/38] sound: ac97: " Levente Kurusa
2013-12-19 16:17 ` Takashi Iwai
2013-12-19 15:03 ` [PATCH 23/38] sound: soc: " Levente Kurusa
2013-12-21 14:31 ` Mark Brown
2013-12-19 15:03 ` [PATCH 24/38] pcmcia: " Levente Kurusa
2013-12-19 15:03 ` [PATCH 25/38] pnp: card: " Levente Kurusa
2014-01-05 22:04 ` Rafael J. Wysocki
2013-12-19 15:03 ` [PATCH 26/38] xen: xenbus: " Levente Kurusa
2014-01-02 13:53 ` David Vrabel [this message]
2014-01-06 10:00 ` [Xen-devel] " Ian Campbell
2014-01-06 11:00 ` David Vrabel
2014-01-06 11:09 ` Ian Campbell
2013-12-19 15:03 ` [PATCH 27/38] superhyway: " Levente Kurusa
2013-12-19 15:03 ` [PATCH 28/38] superhyway: intc: " Levente Kurusa
2013-12-19 15:03 ` [PATCH 29/38] superhyway: maple: " Levente Kurusa
2013-12-19 15:03 ` [PATCH 30/38] vlynq: " Levente Kurusa
2013-12-19 17:37 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C56F43.6030804@citrix.com \
--to=david.vrabel@citrix.com \
--cc=akpm@linux-foundation.org \
--cc=boris.ostrovsky@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=levex@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox