From: Larry Finger <Larry.Finger@lwfinger.net>
To: Tim Jester-Pfadt <t.jp@gmx.de>, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8188eu: Fixed coding style issues
Date: Thu, 02 Jan 2014 11:53:43 -0600 [thread overview]
Message-ID: <52C5A7A7.7020903@lwfinger.net> (raw)
In-Reply-To: <20140102170356.GA29980@archlinux>
On 01/02/2014 11:03 AM, Tim Jester-Pfadt wrote:
> Fixed indentation coding style issues on rtw_io.c
>
> Signed-off-by: Tim Jester-Pfadt <t.jp@gmx.de>
> ---
> drivers/staging/rtl8188eu/core/rtw_io.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_io.c b/drivers/staging/rtl8188eu/core/rtw_io.c
> index 10c9c65..69b408e 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_io.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_io.c
> @@ -205,7 +205,7 @@ void _rtw_read_mem(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)
>
> _func_enter_;
> if (adapter->bDriverStopped || adapter->bSurpriseRemoved) {
> - RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> + RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> ("rtw_read_mem:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
> adapter->bDriverStopped, adapter->bSurpriseRemoved));
> return;
> @@ -239,7 +239,7 @@ void _rtw_read_port(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem)
> _func_enter_;
>
> if (adapter->bDriverStopped || adapter->bSurpriseRemoved) {
> - RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> + RT_TRACE(_module_rtl871x_io_c_, _drv_info_,
> ("rtw_read_port:bDriverStopped(%d) OR bSurpriseRemoved(%d)",
> adapter->bDriverStopped, adapter->bSurpriseRemoved));
> return;
Did you run checkpatch.pl on this patch? You fixed the indents on the RT_TRACE
statements, but the alignment of the continuing statements is wrong. That part
was correct before.
Larry
next prev parent reply other threads:[~2014-01-02 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 17:03 [PATCH] Staging: rtl8188eu: Fixed coding style issues Tim Jester-Pfadt
2014-01-02 17:53 ` Larry Finger [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-04-30 8:30 [PATCH] Staging: rtl8188eu: fixed " Jacky Boen
2016-04-30 16:15 ` Greg KH
2013-12-31 2:53 [PATCH] Staging: rtl8188eu: Fixed " Tim Jester-Pfadt
2013-12-31 3:38 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C5A7A7.7020903@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=t.jp@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox