From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Libo Chen <clbchenlibo.chen@huawei.com>,
David Miller <davem@davemloft.net>
Cc: edumazet@google.com, kaber@trash.net, peterz@infradead.org,
honkiko@gmail.com, netdev@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
cgroups@vger.kernel.org, containers@lists.linux-foundation.org,
jhs@mojatatu.com, Li Zefan <lizefan@huawei.com>,
Serge Hallyn <serge.hallyn@ubuntu.com>
Subject: Re: [RFC PATCH net-next 3/4] veth: backup classid befor switch net_ns
Date: Fri, 03 Jan 2014 14:45:19 +0400 [thread overview]
Message-ID: <52C694BF.3020903@cogentembedded.com> (raw)
In-Reply-To: <52C62A52.8050003@huawei.com>
Hello.
On 03-01-2014 7:11, Libo Chen wrote:
> dev_forward_skb will clear skb->sk, so we need save classid
> before that, otherwise the skb can not be under control by
> net_cls.
> Signed-off-by: Libo Chen <clbchenlibo.chen@huawei.com>
> ---
> drivers/net/veth.c | 7 +++++++
> 1 file changed, 7 insertions(+)
> diff --git a/drivers/net/veth.c b/drivers/net/veth.c
> index 2ec2041..ce43a2d 100644
> --- a/drivers/net/veth.c
> +++ b/drivers/net/veth.c
[...]
> @@ -123,6 +124,12 @@ static netdev_tx_t veth_xmit(struct sk_buff *skb, struct net_device *dev)
> rcv->features & NETIF_F_RXCSUM)
> skb->ip_summed = CHECKSUM_UNNECESSARY;
>
> + /**
Why you're using kernel-doc style comments out of place? The format of
multi-line comments in the networking code is this:
/* bla
* bla
*/
> + * dev_forward_sbk will clear skb->sk, so save
> + * skb->sk->sk_classid for Qos
> + */
> + bk_cls_classid(skb);
> +
WBR, Sergei
next prev parent reply other threads:[~2014-01-03 10:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 3:11 [RFC PATCH net-next 3/4] veth: backup classid befor switch net_ns Libo Chen
2014-01-03 10:45 ` Sergei Shtylyov [this message]
2014-01-06 2:16 ` Libo Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C694BF.3020903@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=cgroups@vger.kernel.org \
--cc=clbchenlibo.chen@huawei.com \
--cc=containers@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=honkiko@gmail.com \
--cc=jhs@mojatatu.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=serge.hallyn@ubuntu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox