From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752977AbaACSSF (ORCPT ); Fri, 3 Jan 2014 13:18:05 -0500 Received: from mga11.intel.com ([192.55.52.93]:49351 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751263AbaACSSD (ORCPT ); Fri, 3 Jan 2014 13:18:03 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.95,599,1384329600"; d="scan'208";a="459722835" Message-ID: <52C6FED2.7070700@intel.com> Date: Fri, 03 Jan 2014 10:17:54 -0800 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: linux-kernel@vger.kernel.org, Andrea Arcangeli , Mel Gorman , Andrew Morton , linux-mm@kvack.org, Michal Hocko Subject: Re: [RFC] mm: show message when updating min_free_kbytes in thp References: <20140101002935.GA15683@localhost.localdomain> <52C5AA61.8060701@intel.com> <20140103033303.GB4106@localhost.localdomain> In-Reply-To: <20140103033303.GB4106@localhost.localdomain> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/02/2014 07:33 PM, Han Pingtian wrote: > @@ -130,8 +130,11 @@ static int set_recommended_min_free_kbytes(void) > (unsigned long) nr_free_buffer_pages() / 20); > recommended_min <<= (PAGE_SHIFT-10); > > - if (recommended_min > min_free_kbytes) > + if (recommended_min > min_free_kbytes) { > + pr_info("raising min_free_kbytes from %d to %d to help transparent hugepage allocations\n", > + min_free_kbytes, recommended_min); > min_free_kbytes = recommended_min; > + } > setup_per_zone_wmarks(); > return 0; > } I know I gave you that big bloated string, but 108 columns is a _wee_ bit over 80. :) Otherwise, I do like the new message