From: Michal Marek <mmarek@suse.cz>
To: Rusty Russell <rusty@rustcorp.com.au>,
LKML <linux-kernel@vger.kernel.org>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] scripts/gcc-version.sh: handle CC="gcc -m32"
Date: Fri, 03 Jan 2014 21:34:34 +0100 [thread overview]
Message-ID: <52C71EDA.6090706@suse.cz> (raw)
In-Reply-To: <52C6EF1C.9070809@suse.cz>
On 3.1.2014 18:10, Michal Marek wrote:
> On 2013-12-10 08:13, Rusty Russell wrote:
>> Without it we get ugly warnings (though build still succeeds).
>>
>> $ make -j8 CC="gcc -m32"
>> In file included from <command-line>:0:0:
>> /usr/include/stdc-predef.h:30:26: fatal error: bits/predefs.h: No such file or directory
>> #include <bits/predefs.h>
>> ^
>> compilation terminated.
>> In file included from <command-line>:0:0:
>> /usr/include/stdc-predef.h:30:26: fatal error: bits/predefs.h: No such file or directory
>> #include <bits/predefs.h>
>> ^
>> compilation terminated.
>> /home/rusty/devel/kernel/linux/scripts/gcc-version.sh: line 31: printf: #: invalid number
>> /home/rusty/devel/kernel/linux/scripts/gcc-version.sh: line 31: printf: #: invalid number
>> /bin/sh: 1: [: 0001: unexpected operator
>> CHK include/config/kernel.release
>> CHK include/generated/uapi/linux/version.h
>> make[1]: Nothing to be done for `all'.
>> ...
>>
>> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
>>
>> diff --git a/scripts/gcc-version.sh b/scripts/gcc-version.sh
>> index 7f2126df91f2..d48b0cbaf246 100644
>> --- a/scripts/gcc-version.sh
>> +++ b/scripts/gcc-version.sh
>> @@ -14,7 +14,7 @@ if [ "$1" = "-p" ] ; then
>> shift;
>> fi
>>
>> -compiler="$*"
>> +compiler="$1"
>
> But this will break things like CC="ccache gcc". Your problem is that
> you do not have the 32bit glibc headers, right?
BTW, what is the usecase for CC="gcc -m32"? AFAICS, at least x86 and
powerpc do this for you when building a 32bit kernel.
Thanks,
Michal
next prev parent reply other threads:[~2014-01-03 20:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 7:13 [PATCH] scripts/gcc-version.sh: handle CC="gcc -m32" Rusty Russell
2014-01-03 17:10 ` Michal Marek
2014-01-03 20:34 ` Michal Marek [this message]
2014-01-15 4:18 ` Rusty Russell
2014-01-16 15:34 ` Michal Marek
2014-01-16 22:26 ` Rusty Russell
2014-01-22 4:39 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C71EDA.6090706@suse.cz \
--to=mmarek@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).