linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Greg Kroah-Hartman <greg@kroah.com>
Cc: Ming Lei <ming.lei@canonical.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/3] firmware loader: Add sparse annotation
Date: Sat, 04 Jan 2014 14:20:36 +0100	[thread overview]
Message-ID: <52C80AA4.7070008@acm.org> (raw)
In-Reply-To: <52C80A50.3000602@acm.org>

Avoid that sparse reports the following warning on __fw_free_buf():

drivers/base/firmware_class.c:230:9: warning: context imbalance in '__fw_free_buf' - unexpected unlock

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Cc: Ming Lei <ming.lei@canonical.com>
---
 drivers/base/firmware_class.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index eb8fb94..c2e4540 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -219,6 +219,7 @@ static int fw_lookup_and_allocate_buf(const char *fw_name,
 }
 
 static void __fw_free_buf(struct kref *ref)
+	__releases(&fwc->lock)
 {
 	struct firmware_buf *buf = to_fwbuf(ref);
 	struct firmware_cache *fwc = buf->fwc;
-- 
1.8.1.4


  parent reply	other threads:[~2014-01-04 13:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-04 13:19 [0/3] Driver core patches for kernel 3.14 Bart Van Assche
2014-01-04 13:20 ` [PATCH 1/3] kobject: Fix source code comment spelling Bart Van Assche
2014-01-04 13:20 ` Bart Van Assche [this message]
2014-01-08  1:40   ` [PATCH 2/3] firmware loader: Add sparse annotation Ming Lei
2014-01-04 13:21 ` [PATCH 3/3] driver-core: Fix use-after-free triggered by bus_unregister() Bart Van Assche
2014-01-08  2:01   ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52C80AA4.7070008@acm.org \
    --to=bvanassche@acm.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).