From: Libo Chen <clbchenlibo.chen@huawei.com>
To: John Fastabend <john.fastabend@gmail.com>
Cc: David Miller <davem@davemloft.net>, <edumazet@google.com>,
<jasowang@redhat.com>, <horms@verge.net.au>,
<serge.hallyn@ubuntu.com>, <netdev@vger.kernel.org>,
<cgroups@vger.kernel.org>,
<containers@lists.linux-foundation.org>, <kaber@trash.net>,
<xemul@openvz.org>, <ebiederm@xmission.com>,
<linux-kernel@vger.kernel.org>, <jhs@mojatatu.com>,
<lizefan@huawei.com>
Subject: Re: [RFC PATCH net-next 1/4] net: introduce backup_classid to struct skbuff
Date: Mon, 6 Jan 2014 16:16:59 +0800 [thread overview]
Message-ID: <52CA667B.4090606@huawei.com> (raw)
In-Reply-To: <52C656F2.8060803@gmail.com>
On 2014/1/3 14:21, John Fastabend wrote:
> On 01/02/2014 09:34 PM, David Miller wrote:
>> From: Libo Chen <clbchenlibo.chen@huawei.com>
>> Date: Fri, 3 Jan 2014 11:11:04 +0800
>>
>>>
>>> introduce backup_classid to struct skbuff,
>>> we can use it to backup sk_classid when net_ns switch.
>>>
>>> Signed-off-by: Libo Chen <clbchenlibo.chen@huawei.com>
>>
>> Sorry, no new sk_buff members unless there is absolutely not other
>> possible implementation.
>>
>> sk_buff is too big as-is.
>
> To get what you want fix the dev_forward_skb() call. But its
> not clear to me why you would expect the sock info to be propagated
> like this. It seems like an incorrect assumption or a misunderstanding
> somewhere. If the virtual link was a physical link you wouldn't expect
> to know anything about the senders socket.
AFAIK, once the sock is created, sock->sk_classid will be set, see sk_alloc()
so I think it is safe.
thanks,
Libo
>
> Thanks,
> John
>
next prev parent reply other threads:[~2014-01-06 8:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 3:11 [RFC PATCH net-next 1/4] net: introduce backup_classid to struct skbuff Libo Chen
2014-01-03 5:34 ` David Miller
2014-01-03 6:21 ` John Fastabend
2014-01-06 8:16 ` Libo Chen [this message]
2014-01-07 12:54 ` Libo Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CA667B.4090606@huawei.com \
--to=clbchenlibo.chen@huawei.com \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=horms@verge.net.au \
--cc=jasowang@redhat.com \
--cc=jhs@mojatatu.com \
--cc=john.fastabend@gmail.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=serge.hallyn@ubuntu.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox