Re: [PATCH] comedi: Humusoft MF634 and MF624 DAQ cards driver

Rostislav Lisovy
2014-01-09T22:56:06Z

On Wed, 2014-01-08 at 10:47 +0300, Dan Carpenter wrote:
> On Tue, Jan 07, 2014 at 11:24:57PM +0100, Rostislav Lisovy wrote:
> > This patch adds Comedi driver for Humusoft MF634 (PCIe) and
> > MF624 (PCI) data acquisition cards. The legacy card Humusoft
> > MF614 is not supported. More info about the cards may be found
> > at http://humusoft.cz/produkty/datacq/
> > The driver was tested with both cards. Everything seems to work
> > properly. Just the basic functionality of the card (DIO, ADC, DAC)
> > is supported by this driver.
> >
> > Signed-off-by: Rostislav Lisovy <lisovy@gmail.com>
> >
> > create mode 100644 drivers/staging/comedi/drivers/mf6x4.c
> >
>
> There should be a "---" after the Signed-off-by line and before the
> diffstat "create mode 100644 drivers/staging/comedi/drivers/mf6x4.c"
> line. Otherwise, the diffstat gets included in the changelog.

I just resent the v3 patch with this flaw corrected. What surprises me a
bit is the fact that the issue was caused by the 'git format-patch'
command called with '--summary' argument. The dashes are included
properly when the argument is not used. Does it make sense?

Regards;
Rostislav Lisovy