Re: [PATCH 15/85] drivers: gpu: Mark function as static in ctxnvd7.c

[Maarten Lankhorst <maarten.lankhorst@canonical.com>]

op 06-01-14 16:11, Rashika Kheria schreef:
> Mark function nvd7_grctx_generate_main() as static in
> drm/nouveau/core/engine/graph/ctxnvd7.c because it is not used outside
> this file.
>
> This eliminates the following warning in
> drm/nouveau/core/engine/graph/ctxnvd7.c:
> drivers/gpu/drm/nouveau/core/engine/graph/ctxnvd7.c:215:1: warning: no previous prototype for ‘nvd7_grctx_generate_main’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> ---
>  .../gpu/drm/nouveau/core/engine/graph/ctxnvd7.c    |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/core/engine/graph/ctxnvd7.c b/drivers/gpu/drm/nouveau/core/engine/graph/ctxnvd7.c
> index c4740d5..0e126ce 100644
> --- a/drivers/gpu/drm/nouveau/core/engine/graph/ctxnvd7.c
> +++ b/drivers/gpu/drm/nouveau/core/engine/graph/ctxnvd7.c
> @@ -211,7 +211,7 @@ nvd7_grctx_generate_mods(struct nvc0_graph_priv *priv, struct nvc0_grctx *info)
>  	mmio_list(0x17e91c, 0x03060609, 0, 0); /* different from kepler */
>  }
>  
> -void
> +static void
>  nvd7_grctx_generate_main(struct nvc0_graph_priv *priv, struct nvc0_grctx *info)
>  {
>  	struct nvc0_grctx_oclass *oclass = (void *)nv_engine(priv)->cclass;
Acked-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>

Building with -Wmissing-prototypes? Good luck fixing radeon! it's a mess. :(