From: Randy Dunlap <rdunlap@infradead.org>
To: "David E. Box" <david.e.box@linux.intel.com>
Cc: mjg59@srcf.ucam.org, rjw@rjwysocki.net,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v6][RESEND] platform: x86: New BayTrail IOSF-SB MBI driver
Date: Tue, 07 Jan 2014 11:30:55 -0800 [thread overview]
Message-ID: <52CC55EF.90006@infradead.org> (raw)
In-Reply-To: <20140107184805.GA28135@linux.intel.com>
On 01/07/14 10:48, David E. Box wrote:
> On Tue, Jan 07, 2014 at 10:15:03AM -0800, Randy Dunlap wrote:
>> On 01/07/14 10:03, David E. Box wrote:
>>> From: "David E. Box" <david.e.box@linux.intel.com>
>>>
>>> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
>>> index b51a746..6e199a5 100644
>>> --- a/drivers/platform/x86/Kconfig
>>> +++ b/drivers/platform/x86/Kconfig
>>> @@ -819,4 +819,14 @@ config PVPANIC
>>> a paravirtualized device provided by QEMU; it lets a virtual machine
>>> (guest) communicate panic events to the host.
>>>
>>> +config INTEL_BAYTRAIL_MBI
>>> + tristate
>>
>> Is this kconfig option displayed when you run menuconfig/nconfig/xconfig/gconfig etc.?
>> Doesn't it need a prompt string?
>> How did you enable it and test it?
>>
>
> It is not displayed on purpose. The driver isn't exposed to user space.
> It was tested by adding the option to .config, both as module and built-in.
>
>>> + depends on PCI
>>> + ---help---
>>> + Needed on Baytrail platforms for access to the IOSF Sideband Mailbox
>>> + Interface. This is a requirement for systems that need to configure
>>> + the PUNIT for power management features such as RAPL. Register
>>> + addresses and r/w opcodes are defined in
>>
>> Think of users reading this. At least change "r/w" to read/write.
>> What is IOSF? does it matter here?
>> PUNIT? RAPL?
>>
>
> If you don't know what the IOSF Sideband is you probably shouldn't be enabling
> this feature. Users of this driver (of which for now there are few) will be
> kernel space drivers that should have ample knowledge of the registers this
> interface provides access to.
I see. Thanks.
--
~Randy
next prev parent reply other threads:[~2014-01-07 19:31 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 6:05 [PATCH 1/2] New Driver for IOSF-SB MBI access on Intel SOCs David E. Box
2013-11-22 6:05 ` [PATCH 2/2] ACPI / platform: Add ACPI ID for Intel IOSF-SB David E. Box
2013-11-22 18:18 ` [PATCH 1/2] New Driver for IOSF-SB MBI access on Intel SOCs Matthew Garrett
2013-11-24 0:41 ` One Thousand Gnomes
2013-12-03 23:59 ` [PATCHv2 0/2] New driver for Intel IOSF MBI access David E. Box
2013-12-03 23:59 ` [PATCHv2 1/2] New Driver for IOSF-SB MBI access on Intel SOCs David E. Box
2013-12-04 6:44 ` Andi Kleen
2013-12-03 23:59 ` [PATCHv2 2/2] ACPI/platform: Add ACPI ID for Intel MBI device David E. Box
2013-12-04 1:30 ` Matthew Garrett
2013-12-04 2:17 ` David E. Box
2013-12-04 2:21 ` Matthew Garrett
2013-12-04 2:44 ` David E. Box
2013-12-04 2:54 ` Matthew Garrett
2013-12-04 21:34 ` Rafael J. Wysocki
2013-12-05 20:01 ` [PATCH] X86 platform: New IOSF-SB MBI driver for Intel SOCs David E. Box
2013-12-05 22:32 ` Rafael J. Wysocki
2013-12-06 20:59 ` [PATCH] X86 platform: New BayTrail IOSF-SB MBI driver David E. Box
2013-12-07 1:29 ` Rafael J. Wysocki
2013-12-10 1:11 ` David E. Box
2013-12-19 22:37 ` [PATCH v5][RESEND] " David E. Box
2013-12-20 1:59 ` Rafael J. Wysocki
2013-12-20 7:01 ` David E. Box
2013-12-30 18:12 ` [PATCH v6] " David E. Box
2014-01-07 18:03 ` [PATCH v6][RESEND] platform: x86: " David E. Box
2014-01-07 18:15 ` Randy Dunlap
2014-01-07 18:48 ` David E. Box
2014-01-07 19:30 ` Randy Dunlap [this message]
2014-01-07 20:46 ` Rafael J. Wysocki
2014-01-07 21:43 ` David E. Box
2014-01-08 0:11 ` Rafael J. Wysocki
2014-01-08 0:00 ` H. Peter Anvin
2014-01-08 5:27 ` David E. Box
2014-01-08 13:47 ` Rafael J. Wysocki
2014-01-08 21:27 ` [PATCH v7] arch: x86: New MailBox support driver for Intel SOC's David E. Box
2014-01-10 22:10 ` [tip:x86/platform] " tip-bot for David E. Box
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CC55EF.90006@infradead.org \
--to=rdunlap@infradead.org \
--cc=david.e.box@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).